-
Notifications
You must be signed in to change notification settings - Fork 303
Draft of 1.24 announcement #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@rust-lang/core please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We may want to add something about the cargo working directory breakage, but I'm not too worried about it.
This is still not the end story for compiler performance generally, nor incremental compilation | ||
specifically. We have a lot more work planned in the future. For example, another change | ||
related to performance hit stable this release: | ||
[`codegen-units` is now set to 16 by default](https://github.com/rust-lang/rust/pull/46910). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth mentioning that this will likely make builds faster, but final products slower.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny little misspelling to fix, content looks great! ❤️
_posts/2018-02-15-Rust-1.24.md
Outdated
> the compiler, like the RLS and Clippy, in the future. | ||
|
||
Finally, please take note of that `-preview` in the name: `rustfmt` is still not quite | ||
at 1.0 yet. Some tweaks to the default styles are still occuring, though they're relatively |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/occuring/occurring/
_posts/2018-02-15-Rust-1.24.md
Outdated
|
||
### Library stabilizations | ||
|
||
If you're a fan of `str::find`, used to find a given `char` inside of a `&str`, you'll be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to put which is
in front of used. I had to reread the sentence a few times thinking the wording was a typo
_posts/2018-02-15-Rust-1.24.md
Outdated
|
||
#### Incremental compilation | ||
|
||
Back in September, we blogged about [Incremental Compilation](https://blog.rust-lang.org/2016/09/08/incremental.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this post is from September 2016 (!) already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say anything about the expected performance wins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It very much depends on what you are compiling and what changes you made. "twice as fast" seems to be a good bet, looking at http://perf.rust-lang.org. For cargo check
it might be different (better, hopefully) but we don't track that on perf.rlo yet.
_posts/2018-02-15-Rust-1.24.md
Outdated
changed, which means that that second build is faster. | ||
|
||
As of Rust 1.24, this is now [turned on by default](https://github.com/rust-lang/cargo/pull/4817). | ||
This means that your builds should get faster! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mention that cargo check
should be used to get the best possible edit-compile cycle; can reference previous release announcement about that. I don't think we've done enough advertising of this as the recommended workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do we have documentation somewhere that says when cargo defaults to incr. comp. and when it doesn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't believe we do
_posts/2018-02-15-Rust-1.24.md
Outdated
`rustup update stable`, `rustfmt-preview` will be updated as well. | ||
|
||
> This strategy is expected to be used for other developer tools that integrate tightly with | ||
> the compiler, like the RLS and Clippy, in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already do this for RLS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but we've never talked about it before, so i phrased it that way
_posts/2018-02-15-Rust-1.24.md
Outdated
at 1.0 yet. Some tweaks to the default styles are still occuring, though they're relatively | ||
minor. Once `rustfmt` hits 1.0, we'll be releasing a `rustfmt` component and | ||
deprecating `rustfmt-preview`. Since this is the first major component we're distributing | ||
this way, we wanted to clearly signal that it is still developing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MIght want to say something about this will happen without any user interaction - rustup will handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and it's the second component - you also have to use rls-preview
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above; we've never talked about rls-preview
_posts/2018-02-15-Rust-1.24.md
Outdated
deprecating `rustfmt-preview`. Since this is the first major component we're distributing | ||
this way, we wanted to clearly signal that it is still developing. | ||
|
||
For more, please check out [`rustfmt` on GitHub](https://github.com/rust-lang-nursery/rustfmt). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to say that if you've previously installed rustfmt with Cargo then you'll have to remove it, but that rustup should tell you about that.
updated to incorporate everyone's feedback |
No description provided.