Rename ESP32 to XTensaLX6 and split crate into rt and base #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle split in xtensa-lx6-rt
This reverts commit e094271.
|
r? @burrbull (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
MabezDev
suggested changes
Jun 8, 2020
Co-authored-by: Scott Mabin <mabezdev@gmail.com>
burrbull
approved these changes
Jun 8, 2020
|
bors r+ |
|
👎 Rejected by code reviews |
|
cc @MabezDev |
MabezDev
approved these changes
Jun 9, 2020
|
bors r+ |
|
@burrbull Thanks for the speedy review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames ESP32 (SOC name) to XtensaLX6 (CPU name) to align to convention of other platforms.
It also adds seperate xtensa-lx6-rt and xtensa-lx6 support (instead of just xtensa-lx6-rt).