This repository was archived by the owner on Aug 9, 2022. It is now read-only.
Changed to split xtensa-lx6-rt, add AES and add output svd to repo #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arjanmels
commented
Jun 7, 2020
arjanmels
commented
- Updated for split xtensa-lx6-rt
- Added AES peripheral (not included in header files), because it causes issues with new svd parser for svd2rust
- Added output svd file to repo (remove from .gitignore) because it is used in testing svd2rust.
|
@MabezDev I just entered the PR for svd2rust (rust-embedded/svd2rust#448) This PR request depends on that one as I renamed the CPU to XtensaLX6 (from ESP32), so includes a change to the makefile. (Also the reason Travis CI fails.) |
|
the svd2rust PR just merged, mind updating the ci to use that? I think you can pass |
|
I'll take a look |
|
@MabezDev I just bumped the code by amending the latest commit: passes now. (I don't think there is a need to include a specific rev: guess we should try to keep up to date with latest svd2rust.) |
|
LGTM! Thanks. |
|
I've also published 0.5.0 including these changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.