Skip to content

Cluster name qualification #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2020
Merged

Cluster name qualification #444

merged 2 commits into from
May 12, 2020

Conversation

gkelly
Copy link
Contributor

@gkelly gkelly commented May 12, 2020

This contains two commits, the first is a simple typo fix. The second ensures that the complete-pathed type name is generated for clusters.

@gkelly gkelly requested a review from a team as a code owner May 12, 2020 03:08
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @burrbull (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels May 12, 2020
@gkelly gkelly mentioned this pull request May 12, 2020
Closed
8 tasks
@gkelly
Fix cluster type name generation
139cadc 
Cluster type names were being generated without considering their full
path. Include the full type path in their instance type names. Also
consolidate `name_to_ty` into a helper function.
@gkelly gkelly force-pushed the cluster-name-qualification branch from a6605d3 to 139cadc Compare May 12, 2020 03:14
@burrbull
Copy link
Member

Thanks.
bors r+

@bors
Copy link
Contributor

bors bot commented May 12, 2020

Build succeeded:

@bors bors bot merged commit 99b5c17 into rust-embedded:master May 12, 2020
@gkelly gkelly deleted the cluster-name-qualification branch May 12, 2020 11:55
gkelly added a commit to gkelly/atsamd that referenced this pull request May 14, 2020
@gkelly
Use bleeding-edge svd2rust
cc8c0f8 
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444)
recently went into the `svd2rust` and `svd-parser` crates. Until these
changes are part of a release have `update.sh` pull a fork of `svd2rust`
that uses the master version of `svd-parser`.
gkelly added a commit to gkelly/atsamd that referenced this pull request May 14, 2020
@gkelly
Use bleeding-edge svd2rust
e9a405b 
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444)
recently went into the `svd2rust` and `svd-parser` crates. Until these
changes are part of a release have `update.sh` pull a fork of `svd2rust`
that uses the master version of `svd-parser`.

See atsamd-rs#195.
@gkelly gkelly mentioned this pull request May 14, 2020
Merged
gkelly added a commit to gkelly/atsamd that referenced this pull request May 14, 2020
@gkelly
Use bleeding-edge svd2rust
2b84214 
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444)
recently went into the `svd2rust` and `svd-parser` crates that improves
the handling of cluster names and the generation of full type paths for
cluster instances. Until these changes are part of a release have
`update.sh` pull a fork of `svd2rust` that uses the master version of
`svd-parser`.

See atsamd-rs#195.
sajattack pushed a commit to atsamd-rs/atsamd that referenced this pull request May 16, 2020
@gkelly @sajattack
Use bleeding-edge svd2rust
5d64c7d 
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444)
recently went into the `svd2rust` and `svd-parser` crates that improves
the handling of cluster names and the generation of full type paths for
cluster instances. Until these changes are part of a release have
`update.sh` pull a fork of `svd2rust` that uses the master version of
`svd-parser`.

See #195.
@burrbull
Copy link
Member

burrbull commented Jun 2, 2020

Something strange with dimable_name_check regex:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=cc2c9f848d4144df27f48af6ed6c516e

It's always true!!!

derived_from fields also can contain dots inside

@gkelly
Copy link
Contributor Author

gkelly commented Jun 2, 2020

Something strange with dimable_name_check regex:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=cc2c9f848d4144df27f48af6ed6c516e

It's always true!!!

derived_from fields also can contain dots inside

Hmm. I wonder if the ^$ are binding to the | groups instead of the whole pattern. Looks like it. I can do a follow up PR to fix that.

@gkelly
Copy link
Contributor Author

gkelly commented Jun 2, 2020

Created rust-embedded/svd#122 to address the naming issue.

kaizensparc pushed a commit to kaizensparc/atsamd that referenced this pull request Dec 24, 2021
@gkelly @sajattack
Use bleeding-edge svd2rust
f0701bd 
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444)
recently went into the `svd2rust` and `svd-parser` crates that improves
the handling of cluster names and the generation of full type paths for
cluster instances. Until these changes are part of a release have
`update.sh` pull a fork of `svd2rust` that uses the master version of
`svd-parser`.

See atsamd-rs#195.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

Assignees

@burrbull burrbull

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkelly @rust-highfive @burrbull