-
Notifications
You must be signed in to change notification settings - Fork 59
Support dimableIdentifierType
-style names
#119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://docs.rs/once_cell/1.3.1/once_cell/sync/struct.Lazy.html static PATTERN: Lazy<Regex> = Lazy::new(|| {
Regex::new("^[_A-Za-z0-9]*$").unwrap()
}); |
Done. |
As of CMSIS-SVD 1.3.3 the schema allows for `dimableIdentifierType` names in several places. This change uses the regular expressions from the CMSIS-SVD 1.3.6 XSD for both `dimableIdentifierType` and `identifierType`. While there is prose in ARM documentation suggesting that all names must be valid ANSI C identifiers this is not born out by the schema constraints.
Ran |
I believe this is ready for review, but I'm unsure what the correct way to request reviewers on this repo is. Is there a queue I can put this in? Not trying to rush anyone, just want to make sure it doesn't fall through the cracks. :) |
bors try |
tryBuild succeeded: |
bors r+ |
Build succeeded: |
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444) recently went into the `svd2rust` and `svd-parser` crates. Until these changes are part of a release have `update.sh` pull a fork of `svd2rust` that uses the master version of `svd-parser`.
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444) recently went into the `svd2rust` and `svd-parser` crates. Until these changes are part of a release have `update.sh` pull a fork of `svd2rust` that uses the master version of `svd-parser`. See atsamd-rs#195.
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444) recently went into the `svd2rust` and `svd-parser` crates that improves the handling of cluster names and the generation of full type paths for cluster instances. Until these changes are part of a release have `update.sh` pull a fork of `svd2rust` that uses the master version of `svd-parser`. See atsamd-rs#195.
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444) recently went into the `svd2rust` and `svd-parser` crates that improves the handling of cluster names and the generation of full type paths for cluster instances. Until these changes are part of a release have `update.sh` pull a fork of `svd2rust` that uses the master version of `svd-parser`. See #195.
A pair of changes (rust-embedded/svd#119, rust-embedded/svd2rust#444) recently went into the `svd2rust` and `svd-parser` crates that improves the handling of cluster names and the generation of full type paths for cluster instances. Until these changes are part of a release have `update.sh` pull a fork of `svd2rust` that uses the master version of `svd-parser`. See atsamd-rs#195.
As of CMSIS-SVD 1.3.3 the schema allows for
dimableIdentifierType
names in several places. This change uses the regular expressions from
the CMSIS-SVD 1.3.6 XSD for both
dimableIdentifierType
andidentifierType
. While there is prose in ARM documentation suggestingthat all names must be valid ANSI C identifiers this is not born out by
the schema constraints.
This appears to have a net positive effect on the
cargo test
results:Before:
test result: FAILED. 253 passed; 381 failed; 0 ignored; 0 measured; 0 filtered out
After:
test result: FAILED. 424 passed; 210 failed; 0 ignored; 0 measured; 0 filtered out