-
Notifications
You must be signed in to change notification settings - Fork 156
Round up when calculating register size in bytes #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round up when calculating register size in bytes #419
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
bors try |
Seems a bit heavy and weird to do this with floating point operations. |
Co-Authored-By: Daniel Egger <daniel@eggers-club.de>
You're right, it's neater this way. I applied your suggestion. |
tryBuild failed |
I'm wondering if this still has an issue with larger fields, for example if I declare a 17 bit wide register, However, the register width is mapped to to the next power of two, and the register field will actually be 32 bit wide. svd2rust/src/generate/register.rs Line 34 in 325a304
It might make more sense to use the actual width of the register in this calculation, instead of calculating it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
bors r+
Build succeeded |
This fixes the issue in #418.