Skip to content

Make lib.rs accessible to dependers #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make lib.rs accessible to dependers #288

wants to merge 1 commit into from

Conversation

vojtechkral
Copy link

Hi,
we are trying to use svd2rust from a build.rs file. As of now, cargo build-dependencies can't be binaries and using svd2rust as a dependency yields an empty crate. svd2rust has to be installed manually for our build.rs to work.

This is a proposal to fix that. I'm not sure this patch is the right way, but it seems all we need is access to the generate() function and we're good to go.

Thanks!

@vojtechkral vojtechkral requested a review from a team as a code owner May 2, 2019 12:49
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @therealprof (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels May 2, 2019
@therealprof
Copy link
Contributor

I though there was a similar PR to this but I can't find it. Sounds good to me in principle but I'm not a very keen user of build.rs so I'd like to hear other opinions.

CC @rust-embedded/tools

@Emilgardis
Copy link
Member

#214 did indeed do this. I can't reproduce the mentioned issue when using latest changes (currently unreleased, candidate for 0.15) in cargo 1.33.0 (2019-02-12). Unless there's a good reason to add this I think this should be closed.

@Emilgardis Emilgardis added the pending close Issue will be closed if no further comments label May 5, 2019
@vojtechkral
Copy link
Author

Yes, using the current master, it seems to work as expected. I must've gotten 0.14 and master mixed up, sorry.

Is there an ETA for 0.15?

@vojtechkral vojtechkral closed this May 9, 2019
@vojtechkral vojtechkral deleted the lib.rs branch May 9, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending close Issue will be closed if no further comments S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants