Provide library access to code generation #214

tones111 · 2018-05-10T00:27:57Z

This change implements the minimal API described in #207 to allow downstream build.rs scripts to generate the svd2rust output.

Emilgardis

Looks good.

Can you put Target inside util instead?

tones111 · 2018-05-16T02:01:30Z

Rebased and updated for v0.13.0

Emilgardis · 2018-05-16T08:10:06Z

cc @japaric I want to get an ok from you before merging

tones111 · 2018-05-20T01:34:31Z

Rebased for v0.13.1. Instead of returning a tuple a struct with named fields is used to remove ambiguity over the tuple ordering.

rust-embedded#214 (review)

tones111 · 2018-10-20T01:33:38Z

ping @Emilgardis @japaric

I'm still interested in landing this PR. rebased against the current master branch.

therealprof

LGTM, but ALAS we can't make any changes because CI is broken.

jacobrosenthal · 2018-11-23T22:53:05Z

I found myself hacking this in as well. A lof of crates have shell scripts that attempt to cargo install binaries at specific versions. Until thats more doable, making form, svd2rust etc all library usable means we can lock to the correct version in the cargo manifest.

jacobrosenthal · 2018-11-26T22:28:58Z

generate isnt probably the best user facing api, but I have a pretty rough fork that exposes that function, though I wouldn't pr it, as I had to hack on the (i guess now deprecated?) error style used here that I don't really understand how/if theres a good replacement for yet.
https://github.com/jacobrosenthal/svd2rust/tree/lib

It works in concert with a PR into form as well
djmcgill/form#6

Which leads to a cargo alias style script that looks pretty decent and should cross platform and versioned better than the update.sh scripts most people are using
https://github.com/jacobrosenthal/efm32-rs/blob/master/tools/src/bin/gen.rs

Or could be its own full featured crate but Im ambivalent on that atm.

jacobrosenthal · 2018-11-28T03:08:42Z

After I cleaned my version up, it became the naive solution exposing internals tried here and rejected. oops. Sorry for the noise.

Ive successfully utilized this PR now, though it does seem to be missing the build_rs file generation.

Emilgardis

lgtm 👍 , I do still want an approval from @japaric before merging though

jacobrosenthal · 2018-11-28T15:44:38Z

One simple thing thats missing here is the build_rs output. I added it to my commit here and could pr:
jacobrosenthal@0bcc4db

tones111 · 2018-11-29T02:10:27Z

My ultimate goal for this effort is to finish the implementation for stm32-rs/stm32-rs#5

Wouldn't generating the build.rs file prevent the crate from providing its own? In the case of stm32-rs, the crate would be able to cover a large number of devices and the user selects the target with a feature flag. In that case the build.rs file has a bunch of other work to accomplish like extracting the correct svd file from one of the archives in the repo.

jacobrosenthal · 2018-11-29T07:18:34Z

From looking at the tool, it seems like the code path for cortex m targets at the very least wants the (currently hardcoded) build.rs to load the memory.x

If you dont want it you could not save it.

Also you should check out my script (which I wasnt intending to run as a build.rs) where I run a pinned programmatic version of rustfmt instead of using command
https://github.com/jacobrosenthal/efm32-rs/blob/master/tools/src/bin/gen.rs#L25-L31

japaric · 2018-12-04T20:26:23Z

Thanks for the PR @tones111. I agree with @jacobrosenthal that the build.rs file should be part of the Generation output. Also device.x is not always generated so device_x should be Option<String> to indicate that; likewise build_rs should be None if device_x is None so I think we want something like device_x_build_rs: Option<(String, String)> but with a struct instead of a tuple (and better names).

Finally, Generation should have a private field so we can add more public fields to it without bumping the minor version.

Emilgardis

Looks good, just some tiny nit-picks.

src/lib.rs

jacobrosenthal · 2018-12-11T23:49:11Z

I tested this for my use cases and it is working well. Well done @tones111

jacobrosenthal · 2018-12-14T02:39:54Z

Any last requests @therealprof or @japaric can we get a merge (and a point release)

therealprof

LGTM

therealprof · 2018-12-15T20:24:00Z

bors try

bors · 2018-12-15T21:14:46Z

try

Build failed

continuous-integration/travis-ci/push

japaric

LGTM. @tones111 thanks for working on this!

Emilgardis · 2018-12-15T22:20:21Z

try timed out, seems the version of the backtrace crate causing the previous ci fails has been yanked however.

therealprof · 2019-01-22T20:42:57Z

bors try

bors · 2019-01-22T21:47:22Z

try

Build succeeded

continuous-integration/travis-ci/push

therealprof · 2019-01-22T21:55:58Z

bors r+

214: Provide library access to code generation r=therealprof a=tones111 This change implements the minimal API described in #207 to allow downstream build.rs scripts to generate the svd2rust output. Co-authored-by: Paul Sbarra <sbarra.paul@gmail.com> Co-authored-by: Jacob Rosenthal <jacobrosenthal@gmail.com>

bors · 2019-01-22T22:30:46Z

Build succeeded

continuous-integration/travis-ci/push

Emilgardis requested changes May 10, 2018

View reviewed changes

Emilgardis requested a review from japaric May 10, 2018 06:14

Emilgardis previously approved these changes May 10, 2018

View reviewed changes

dfrankland added a commit to dfrankland/svd2rust that referenced this pull request May 26, 2018

Move Target to util module

a16b4c2

rust-embedded#214 (review)

tones111 dismissed Emilgardis’s stale review via 589d4b6 October 16, 2018 01:47

therealprof previously approved these changes Oct 20, 2018

View reviewed changes

jacobrosenthal mentioned this pull request Nov 28, 2018

programmatic library support #262

Closed

Emilgardis previously approved these changes Nov 28, 2018

View reviewed changes

tones111 and others added 2 commits December 8, 2018 18:23

Provide library access to code generation

0f72f01

add build_rs to Generation struct

9e56759

tones111 dismissed stale reviews from Emilgardis and therealprof via 46fd643 December 9, 2018 15:02

tones111 requested a review from a team as a code owner December 9, 2018 15:02

Emilgardis requested changes Dec 10, 2018

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

Segregate device specific generation to its own struct

477531b

Emilgardis approved these changes Dec 12, 2018

View reviewed changes

therealprof approved these changes Dec 15, 2018

View reviewed changes

bors bot added a commit that referenced this pull request Dec 15, 2018

Try #214:

825b45d

japaric approved these changes Dec 15, 2018

View reviewed changes

bors bot added a commit that referenced this pull request Jan 22, 2019

Try #214:

fbce575

bors bot merged commit 477531b into rust-embedded:master Jan 22, 2019

tones111 deleted the lib_generate branch January 27, 2019 17:01

japaric mentioned this pull request Feb 5, 2019

Prepare for new release #276

Closed

Emilgardis mentioned this pull request May 5, 2019

Make lib.rs accessible to dependers #288

Closed

Provide library access to code generation #214

Provide library access to code generation #214

Uh oh!

Conversation

tones111 commented May 10, 2018

Uh oh!

Emilgardis left a comment

Choose a reason for hiding this comment

Uh oh!

tones111 commented May 16, 2018

Uh oh!

Emilgardis commented May 16, 2018

Uh oh!

tones111 commented May 20, 2018

Uh oh!

tones111 commented Oct 20, 2018

Uh oh!

therealprof left a comment

Choose a reason for hiding this comment

Uh oh!

jacobrosenthal commented Nov 23, 2018

Uh oh!

jacobrosenthal commented Nov 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jacobrosenthal commented Nov 28, 2018

Uh oh!

Emilgardis left a comment

Choose a reason for hiding this comment

Uh oh!

jacobrosenthal commented Nov 28, 2018

Uh oh!

tones111 commented Nov 29, 2018

Uh oh!

jacobrosenthal commented Nov 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

japaric commented Dec 4, 2018

Uh oh!

Emilgardis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jacobrosenthal commented Dec 11, 2018

Uh oh!

jacobrosenthal commented Dec 14, 2018

Uh oh!

therealprof left a comment

Choose a reason for hiding this comment

Uh oh!

therealprof commented Dec 15, 2018

Uh oh!

bors bot commented Dec 15, 2018

try

Build failed

Uh oh!

japaric left a comment

Choose a reason for hiding this comment

Uh oh!

Emilgardis commented Dec 15, 2018

Uh oh!

therealprof commented Jan 22, 2019

Uh oh!

bors bot commented Jan 22, 2019

try

Build succeeded

Uh oh!

therealprof commented Jan 22, 2019

Uh oh!

bors bot commented Jan 22, 2019

Build succeeded

Uh oh!

Uh oh!

jacobrosenthal commented Nov 26, 2018 •

edited

Loading

jacobrosenthal commented Nov 29, 2018 •

edited

Loading