add FromUtf8Error in sync with std#640
Open
johann-cm wants to merge 1 commit intorust-embedded:mainfrom
Open
Conversation
The FromUtf8Error allows you to regain ownership over the byte vector that you have moved into the from_utf8 method. This mirrors std.
Contributor
|
Thank you for the PR! I'm not convinced it is that useful The ergonomics of having the Error type have a const-generic and not being |
Contributor
|
I agree with @sgued here and I'm also not a big fan of the breaking change, even if it shouldn't really be too bad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm proposing changing the error type of
String::from_utf8formcore::str::Utf8Errortoheapless::string::FromUtf8Error. This would mirror the error type ofstd::String::from_utf8(which isstd::string::FromUtf8Error). This is a breaking change.FromUtf8Errorhas the advantage that you can regain ownership over the data that you want to convert to UTF-8 in case of an error, which you currently lose in that case.The change would have made it possible for me in #639 to implement
into_stringwithout unsafe code.