Merged
Conversation
sgued
reviewed
Jan 4, 2026
Co-authored-by: Soso <51865119+sgued@users.noreply.github.com>
zeenix
requested changes
Jan 4, 2026
Contributor
zeenix
left a comment
zeenix
left a comment
There was a problem hiding this comment.
I promise, last nicpick. :)
Co-authored-by: Zeeshan Ali Khan <zeenix@gmail.com>
sgued
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've implemented the methods
into_bytes,into_bytes_with_nul, andinto_string, which are present in thestd::ffi::CString.I've also added
thiserroras a dependency to neatly derive theErrortrait on theIntoStringErrorstruct.If you prefer to keep dependencies to an absolute minimum, I can also remove
thiserrorand implement theErrortrait by hand.