Skip to content

Generate debug information for assembly functions #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2020
Merged

Generate debug information for assembly functions #213

merged 1 commit into from
May 3, 2020

Conversation

Tiwalun
Copy link
Contributor

@Tiwalun Tiwalun commented May 3, 2020

This helps with debugging, but makes the binaries a bit larger.

@Tiwalun Tiwalun requested a review from a team as a code owner May 3, 2020 08:58
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels May 3, 2020
@adamgreig
Copy link
Member

To be clear: this makes our object files larger, but shouldn't have any impact on application code size, right?

@Tiwalun
Copy link
Contributor Author

Tiwalun commented May 3, 2020

It makes the final ELF files bigger, the debug information for the assembly function will always be there, regardless of the rustc settings.

The actual code size without debug information is unchanged. For an embedded context, this is probably more relevant.

@adamgreig
Copy link
Member

Sorry, yes, I mean "the final occupied space in the target flash" is unchanged, whereas we don't really care if the elfs are a few bytes larger.

adamgreig
adamgreig approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 3, 2020
@bors @Tiwalun
Merge #213
f84a239 
213: Generate debug information for assembly functions r=adamgreig a=Tiwalun

This helps with debugging, but makes the binaries a bit larger.

Co-authored-by: Dominik Boehi <dominik.boehi@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build failed:

@adamgreig
Copy link
Member

We'll have to wait for #214 which I thought would merge before this.

@adamgreig
Copy link
Member

bors retry

bors bot added a commit that referenced this pull request May 3, 2020
@bors @Tiwalun
Merge #213
157779e 
213: Generate debug information for assembly functions r=adamgreig a=Tiwalun

This helps with debugging, but makes the binaries a bit larger.

Co-authored-by: Dominik Boehi <dominik.boehi@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build failed:

@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build succeeded:

@bors bors bot merged commit d677abe into rust-embedded:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@korken89 korken89

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tiwalun @rust-highfive @adamgreig @korken89