Skip to content

Allow CI on nightly to fail #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2020
Merged

Allow CI on nightly to fail #214

merged 2 commits into from
May 3, 2020

Conversation

jonas-schievink
Copy link
Contributor

No description provided.

@jonas-schievink jonas-schievink requested a review from a team as a code owner May 3, 2020 15:18
@rust-highfive
Copy link

r? @ithinuel

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels May 3, 2020
adamgreig
adamgreig previously approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 3, 2020
@bors @jonas-schievink
Merge #214
40fd018 
214: Allow CI on nightly to fail r=adamgreig a=jonas-schievink



Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build failed:

@adamgreig
Copy link
Member

From travis:

root: both matrix and jobs given, matrix overwrites jobs
root: key matrix is an alias for jobs, using jobs

I guess either add allow_failures to matrix or put ALLOW_FAILURES=1 in the env for each nightly?

@adamgreig adamgreig mentioned this pull request May 3, 2020
Merged
adamgreig
adamgreig approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request May 3, 2020
@bors @jonas-schievink
Merge #214
a0abe08 
214: Allow CI on nightly to fail r=adamgreig a=jonas-schievink



Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build failed:

@adamgreig
Copy link
Member

bors retry

@bors
Copy link
Contributor

bors bot commented May 3, 2020

Build succeeded:

@bors bors bot merged commit 44bde8f into master May 3, 2020
@bors bors bot deleted the jonas-schievink-patch-1 branch May 3, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@ithinuel ithinuel

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonas-schievink @rust-highfive @adamgreig @ithinuel