Check the assembly #83
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust has this weird quirk where
#[inline]functions are not compiled until they are used. Which means any inline-assembly code inside them isn't checked for correctness unless a function is used. For a library exporting a bunch of thin wrappers around inline-assembly, this is an issue.This PR adds a feature to
cortex-arcalledcheck-asm, and if set, it disables the#[inline]attribute, forcing the functions to be checked.Currently (and by default), we can build this for ARMv4T:
However, with this new feature, we see that a bunch of the barrier instructions are not available on that architecture: