Clean up handler comments#201
Merged
jonathanpallant merged 1 commit intoJul 6, 2026
Merged
Conversation
1. Numbers all the steps it takes on entry 2. Matches those numbered steps on exit 3. Uses `// Initial capital letter` for the comments 4. Has a consistent comment for any particular piece of assembly when used across handlers 5. If you need to do an `ldmfd sp!` on exit (usually because that variant can restore `SPSR` to `CPSR`), use matching `stmfd sp!` on entry, even if a `push` would do the same thing - just for consistency and to make the pairing obvious. 6. Removed references to chapters of the ARM ARM ARM, because the right ARM ARM ARM depends on which target you are building. 7. Talks about pushing and popping with the stack, or grabbing and restoring with MRS/MSR Also, doing a `and r12, sp, 7` does it in one instruction whereas before I sometimes used two.
thejpster
force-pushed
the
tidy-up-asm-comments
branch
from
347953d to
6029b49
Compare
robamu
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to make sure every asm handler routine:
// Initial capital letterfor the commentsldmfd sp!on exit (usually because that variant can restoreSPSRtoCPSR), use matchingstmfd sp!on entry, even if apushwould do the same thing - just for consistency and to make the pairing obvious.Also, doing a
and r12, sp, 7does it in one instruction whereas before I sometimes used two.