Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix seeking #133

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Fix seeking #133

merged 7 commits into from
Jun 10, 2024

Commits on Jun 1, 2024

  1. Add new test. 

    Based on #131
    @thejpster
    thejpster committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    83128a3 View commit details
    Browse the repository at this point in the history

  2. Bug fix for #131 

    Start from beginning of file if current position is *ahead* of desired position.
    @thejpster
    thejpster committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    07d7bd2 View commit details
    Browse the repository at this point in the history

  3. Fix read_file_backwards. 

    We weren't actually reading backwards because we always did "seek from start". Now we do some "seek from current" with a negative offset, and a "seek from end".
    @thejpster
    thejpster committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    a3c895b View commit details
    Browse the repository at this point in the history

  4. Fix seek_from_end.

    @thejpster
    thejpster committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    a04e5f0 View commit details
    Browse the repository at this point in the history

  5. Move new test into read_file.

    @thejpster
    thejpster committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    0de58d3 View commit details
    Browse the repository at this point in the history

  6. Code cleanups.

    @thejpster
    thejpster committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    59e4c2f View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Merge branch 'develop' into fix-seeking

    @eldruin
    eldruin authored Jun 6, 2024
    Configuration menu
    Copy the full SHA
    92c8ca9 View commit details
    Browse the repository at this point in the history