Fix seeking #133
Merged
Fix seeking #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on #131
Start from beginning of file if current position is *ahead* of desired position.
|
The test first failed with attempt to subtract with overflow and after the fix it no longer fails. |
We weren't actually reading backwards because we always did "seek from start". Now we do some "seek from current" with a negative offset, and a "seek from end".
eldruin
reviewed
Jun 6, 2024
| /// The last cluster we accessed, and how many bytes that short-cuts us. | ||
| /// | ||
| /// This saves us walking from the very start of the FAT chain when we move | ||
| /// forward through a file. | ||
| pub(crate) current_cluster: (u32, ClusterId), |
There was a problem hiding this comment.
Should this variable be rather called last_cluster_accessed or similar?
There was a problem hiding this comment.
I thought about it, but it changes a bunch of stuff. Maybe in a later PR?
Can you smash that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully closes #131. Now we start from the beginning of a file when the current offset is ahread of the desired offset.