[Bug]: Failed to create pull request

[sitiom]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8313882263#step:2:94

Found forked winget-pkgs repository: coreybutler/winget-pkgs
  Failed to create pull request
  node:internal/errors:841
    const err = new Error(message);
                ^
  
  Error: Command failed: & $env:JAVA_HOME_17_X64\bin\java.exe -jar komac.jar update --id 'CoreyButler.NVMforWindows' --version 1.1.11 --urls 'https://github.com/coreybutler/nvm-windows/releases/download/1.1.11/nvm-setup.exe' --submit
      at checkExecSyncError (node:child_process:828:11)
      at execSync (node:child_process:899:15)
      at D:\a\_actions\vedantmgoyal2009\winget-releaser\v2\dist\index.js:77:39
      at processTicksAndRejections (node:internal/process/task_queues:[96](https://github.com/coreybutler/nvm-windows/actions/runs/4685243965/jobs/8313882263#step:2:97):5) {
    status: 1,
    signal: null,
    output: [ null, null, null ],
    pid: 2592,
    stdout: null,
    stderr: null
  }

[russellbanks]

I'm not too sure on the reason here - I'm thinking it could be a one-time issue and running it again should fix it, but the error isn't too helpful so I'm adding more information to it in the next update

[russellbanks]

I'll also add some retry logic so that if this were to happen again, we could (unless GitHub's servers were down or something) rule out that it needed to be ran again.

[sitiom]

I'm thinking it could be a one-time issue and running it again should fix it, but the error isn't too helpful so I'm adding more information to it in the next update

That was already the 4th attempt (technically 2 attempts; the asset was missing from the first 2 attempts). Manually running the command on my machine worked, though.

[crsib]

The same happens to Audacity now https://github.com/audacity/audacity/actions/runs/4786981931/jobs/8512358422

[russellbanks]

Thanks @crsib - I've added reasoning to the error and retry logic in 1.5.0 that I will release later.

I'm not sure what would cause this just by looking at it because it happens successfully when running manually.

[vedantmgoyal9]

Although it has been defined in the message to show the reason, it is never displayed. Any clue @russellbanks?

• https://github.com/audacity/audacity/actions/runs/4786981931/jobs/8512358422
• https://github.com/electerm/electerm/actions/runs/4625867508/jobs/8256656137

Komac/src/main/kotlin/data/GitHubImpl.kt

Lines 170 to 173 in 2d92db6

	message = """
	Failed to create pull request after $maxTries attempts.
	${ioException.message?.let { "Reason: $it" }}.
	""".trimIndent(),

[russellbanks]

Although it has been defined in the message to show the reason, it is never displayed. Any clue @russellbanks?

Both those jobs were created with Komac 1.4.1. The error reasoning was added in 1.5.0