Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to create PR #376

Closed
1 task done
teras opened this issue Jan 11, 2024 · 6 comments
Closed
1 task done

[Bug]: Unable to create PR #376

teras opened this issue Jan 11, 2024 · 6 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@teras
Copy link

teras commented Jan 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

I know there is already issue #167 but my results seem completely different (and this thread is closed already, so probably it's irrelevant).

When I run Komac version 1.11.0 (the JAR version under Linux) then every time I try to create a PR, I always get this message:
Failed to create branch from upstream default branch

When followed @russellbanks comment here, I downloaded the main branch, compiled Rust version and performed the procedure once more. Then I get another kind of error:

Error: 
   0: Failed to create Jubler.App-8.0.0-12207631941812216045

For your reference the command I am running is

./debug/komac update --identifier Jubler.App --version 8.0.0 --urls https://github.com/teras/Jubler/releases/download/v8.0.0/Jubler-8.0.0.x64.exe

It seems that in any case, all of the times, I am not able to create a new PR?

Thank you for your support.

@teras teras added bug Something isn't working help wanted Extra attention is needed labels Jan 11, 2024
@dpprdan
Copy link

dpprdan commented Jan 11, 2024

@teras Sync your fork https://github.com/teras/winget-pkgs so your master branch is up to date with microsoft/winget-pkgs:master and komac update ... again. Your fork being out of sync with origin upstream is what causes this, I think.

@teras
Copy link
Author

teras commented Jan 12, 2024

This is it, indeed!!! Thank you.

I am thinking, is there any way for the use to be informed about this kind of situations? If there were a proper message for this, I wouldn't bother and open an issue. You people have more serious things to do than this.

I consider myself an experienced developer (in the Linux ecosystem), where from time to time I write/update my multi-platform apps. I have only used once winget for the original transmission and since my workspace is in Linux, I decided to fight with this tool and try to use it instead.

This tools is awesome, user friendly, and really helped me. But I was lost when a generic error happens.

As a suggestion: even the raw logs to be displayed maybe would have been helpful.

@soredake
Copy link

Sync your fork teras/winget-pkgs so your master branch is up to date with microsoft/winget-pkgs:master and komac update ... again. Your fork being out of sync with origin upstream is what causes this, I think.

It would be super nice if komac can have option like --update-master to do this automatically.

@russellbanks
Copy link
Owner

Thanks for your solution @dpprdan and your feedback @teras and @soredake. This has been a helpful issue for me too because I haven't ever been able to reproduce this because I use wei/pull to keep my winget-pkgs fork up-to-date. I'll keep this in mind as it would be good for Komac to have the functionality to update the master branch itself.

@dpprdan
Copy link

dpprdan commented Jan 12, 2024

Similar issue with wingetcreate: microsoft/winget-create#502

@soredake
Copy link

This has been a helpful issue for me too because I haven't ever been able to reproduce this because I use wei/pull to keep my winget-pkgs fork up-to-date.

I didn't know something like this existed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants