Refactor adding modules via CTermSymbolic
#4771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for KAST module simplicity
automergerpr-permission-manager
bot
merged commit 0301a14
into
develop
18 checks passed
automergerpr-permission-manager
bot
deleted the
cterm-symbolic-add-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the ability to add KAST level modules to the RPC server via
CTermSymbolic, so that the user doesn't need to manually do the conversions needed for adding such modules. TheAPRProveris refactored to use this newCTermSymbolic.add_moduleas well.This is part of runtimeverification/kontrol#977, and blocking runtimeverification/kontrol#979.