Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use custom port #420

Closed
doctahpopp opened this issue Sep 10, 2024 · 2 comments
Closed

Unable to use custom port #420

doctahpopp opened this issue Sep 10, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@doctahpopp
Copy link
Contributor

doctahpopp commented Sep 10, 2024 •
edited
Loading

You have the ability to set the targetPort and portName on the service definition, as well as the ability to define ATLANTIS_PORT env variable on the statefulSet to use a custom port with this workload.

However, this does not update the port on container spec or the readinessProbes.

These sections use static blocks
https://github.com/runatlantis/helm-charts/blob/main/charts/atlantis/templates/statefulset.yaml#L238-L240
https://github.com/runatlantis/helm-charts/blob/main/charts/atlantis/templates/statefulset.yaml#L505-L521

Propose updating the chart to use service.targetPort to configure all of the necessary port settings on the chart resources.

Ill cut an MR.
@GMartinez-Sisti GMartinez-Sisti added enhancement New feature or request waiting-on-response Waiting for a response from the user labels Sep 10, 2024
doctahpopp added a commit to doctahpopp/atlantis-helm-charts that referenced this issue Sep 24, 2024
@doctahpopp
Fix(atlantis) Unable to use custom port runatlantis#420
3f8dd0d
@doctahpopp
Copy link
Contributor Author

@GMartinez-Sisti Have a look at the MR let me know we might be able to get it merged!

@GMartinez-Sisti GMartinez-Sisti removed the waiting-on-response Waiting for a response from the user label Sep 25, 2024
doctahpopp added a commit to doctahpopp/atlantis-helm-charts that referenced this issue Sep 25, 2024
@doctahpopp
Fix(atlantis) Unable to use custom port runatlantis#420
b7dcb0c 
update docs

bump minor version

Reset patch version
GMartinez-Sisti pushed a commit that referenced this issue Oct 9, 2024
@doctahpopp
Fix(atlantis) Unable to use custom port #420 (#426)
3f87467 
update docs

bump minor version

Reset patch version
@GMartinez-Sisti
Copy link
Member

Merged on #426.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GMartinez-Sisti @doctahpopp