Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(atlantis) Unable to use custom port #420 #426

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix(atlantis) Unable to use custom port #420 #426

merged 2 commits into from
Oct 9, 2024

Conversation

doctahpopp
Copy link
Contributor

what

  • Provide ability to use the service.TargetPort key to define alternative ports for running atlantis.
  • Extended documentation for the targetPort key to include implications.

why

  • There is partial support for custom ports, but it is not extended to include all port related configurations. This allows for a hollistic approach to custom ports.

tests

Ive extended the helm tests to cover this use-case.

references

closes #420

@doctahpopp doctahpopp requested a review from a team as a code owner September 24, 2024 18:56
@GMartinez-Sisti
Copy link
Member

Hi @doctahpopp, thanks for the contribution. Can you please also bump the minor chart's version (since it's a new feature)? 🙏

@doctahpopp
Copy link
Contributor Author

On it!

@doctahpopp
Fix(atlantis) Unable to use custom port runatlantis#420
b7dcb0c 
update docs

bump minor version

Reset patch version
@doctahpopp
Copy link
Contributor Author

@GMartinez-Sisti is there anything yall need from me here for the failed test ? I see its a UI test failure, but Im not sure what might be causing that.

@GMartinez-Sisti
Copy link
Member

@GMartinez-Sisti is there anything yall need from me here for the failed test ? I see its a UI test failure, but Im not sure what might be causing that.

I need to reproduce this locally and troubleshoot to figure out what's happening. Best guess is that it's a matter of timing, but needs confirmation.

@GMartinez-Sisti
Copy link
Member

This was probably the issue -> #425 (comment) and just merged. Please fix the conflicts and rebase from main so we can check if the CI is able to work now.

@doctahpopp
Copy link
Contributor Author

@GMartinez-Sisti I think we should be good here finally!

@GMartinez-Sisti GMartinez-Sisti merged commit 3f87467 into runatlantis:main Oct 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GMartinez-Sisti GMartinez-Sisti GMartinez-Sisti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doctahpopp @GMartinez-Sisti