Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pr-size-labeler): increase size of xl threshold, disable fail #4529

Merged
merged 1 commit into from
May 10, 2024
Merged

fix(pr-size-labeler): increase size of xl threshold, disable fail #4529

merged 1 commit into from
May 10, 2024

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented May 9, 2024 •
edited
Loading

what

  • increase size of xl threshold
  • disable fail if xl

why

  • explicit message instead of implicit message
  • disable fail message to not irk anyone as we roll out this action
  • increase thresholds since the code base requires many changes (lots of copy paste at times) to get features out

tests

references

@nitrocode nitrocode requested review from a team as code owners May 9, 2024 20:55
@nitrocode nitrocode requested review from chenrui333, lukemassa and X-Guardian and removed request for a team May 9, 2024 20:55
@chenrui333
Copy link
Member

do we really need early optimizations?

@chenrui333
Copy link
Member

as long as it would resolve this issue :)

image

@nitrocode nitrocode merged commit f4a1263 into main May 10, 2024
27 of 28 checks passed
@nitrocode nitrocode deleted the pr-size-label-2 branch May 10, 2024 06:00
@nitrocode nitrocode mentioned this pull request May 10, 2024
Closed
@nitrocode
Copy link
Member Author

@chenrui333 same issue. I put in this PR to fix #4533

@chenrui333
Copy link
Member

can you test it out in some test repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
github-actions size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @chenrui333