Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add pr size labeler #4526

Merged
merged 1 commit into from
May 9, 2024
Merged

feat: add pr size labeler #4526

merged 1 commit into from
May 9, 2024

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented May 9, 2024 •
edited
Loading

what

  • feat: add pr size labeler

why

  • This will label PRs based on the number of lines changed
  • This makes it easier to distinguish between an easy PR to review and a large PR review
  • We can also comment on PRs if there are too many LoC changed to state a PR could be denied or slow to review due to its size

tests

  • This was tested in this PR which got the label of size/s.

references

@nitrocode nitrocode requested review from a team as code owners May 9, 2024 05:08
@nitrocode nitrocode requested review from GenPage, lukemassa and X-Guardian and removed request for a team May 9, 2024 05:08
chenrui333
chenrui333 approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we can certainly give it a shot.

@nitrocode nitrocode merged commit 1475ee6 into main May 9, 2024
27 checks passed
@nitrocode nitrocode deleted the size-labeler.yml branch May 9, 2024 20:50
@nitrocode nitrocode mentioned this pull request May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@jamengual jamengual jamengual approved these changes

@GenPage GenPage Awaiting requested review from GenPage GenPage is a code owner automatically assigned from runatlantis/maintainers

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
github-actions size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nitrocode @chenrui333 @jamengual