Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] ignore commit status for apply jobs (#2135) #2137

Merged
merged 3 commits into from
May 16, 2022
Merged

[fix] ignore commit status for apply jobs (#2135) #2137

merged 3 commits into from
May 16, 2022

Conversation

michelmzs
Copy link
Contributor

@michelmzs michelmzs commented Mar 12, 2022 •
edited
Loading

Fix for the issue #2135.
Behavior started in version 0.18.0, apply jobs are not being ignored during the apply requirements validation.

@michelmzs michelmzs marked this pull request as ready for review April 8, 2022 14:09
@michelmzs michelmzs requested a review from a team as a code owner April 8, 2022 14:09
@carlbordum carlbordum mentioned this pull request May 10, 2022
Closed
@michelmzs michelmzs marked this pull request as draft May 13, 2022 10:12
michelmzs and others added 2 commits May 13, 2022 07:38
@michelmzs
fix: update commit status check logic to match the commit status name
2cc24a8
@michelmzs @Skeen
Update server/events/vcs/gitlab_client.go
7d61513 
chore: simplify ignored statuses logic

Co-authored-by: Emil 'Skeen' Madsen <sovende@gmail.com>
@michelmzs michelmzs marked this pull request as ready for review May 13, 2022 10:41
@michelmzs
Copy link
Contributor Author

Hi @jamengual, could this fix be added to the v0.19.3-pre ?

@jamengual
Copy link
Contributor

@michelmzs can you add some tests?

@jamengual jamengual added bug Something isn't working waiting-on-response Waiting for a response from the user labels May 13, 2022
@michelmzs
Copy link
Contributor Author

Test added @jamengual

@jamengual jamengual merged commit 02a1bb6 into runatlantis:master May 16, 2022
@jamengual
Copy link
Contributor

@michelmzs we will add this to the next prerelease in about two weeks

@michelmzs
Copy link
Contributor Author

michelmzs commented May 16, 2022 •
edited
Loading

Thank you, glad to contribute.

@ascandella ascandella mentioned this pull request May 17, 2022
Merged
@olia-dev olia-dev mentioned this pull request Jun 8, 2022
Closed
@chicocvenancio chicocvenancio mentioned this pull request Jun 10, 2022
Merged
@jamengual
Copy link
Contributor

@michelmzs can you look into #2304 please?

@michelmzs
Copy link
Contributor Author

michelmzs commented Jun 16, 2022 •
edited
Loading

@michelmzs can you look into #2304 please?

@jamengual the fix is ready to review #2312

krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@michelmzs @Skeen @krrrr38
[fix] ignore commit status for apply jobs (runatlantis#2135) (runatla…
0b5e831 
…ntis#2137)

* fix: update commit status check logic to match the commit status name

* Update server/events/vcs/gitlab_client.go

chore: simplify ignored statuses logic

Co-authored-by: Emil 'Skeen' Madsen <sovende@gmail.com>

* feat(gitlab_client_test): add PullIsMergeable test case

Co-authored-by: Emil 'Skeen' Madsen <sovende@gmail.com>
@nitrocode nitrocode added this to the v0.19.4 milestone Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skeen Skeen Skeen left review comments

Assignees
No one assigned
Labels
bug Something isn't working provider/gitlab waiting-on-response Waiting for a response from the user
Projects
None yet
Milestone
v0.19.4
Development

Successfully merging this pull request may close these issues.
4 participants
@michelmzs @jamengual @Skeen @nitrocode