[gitlab] Failed apply jobs not ignored if custom vcs status name is set

[olia-dev]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

The fix introduced with #2137 does only work if you did not set a custom VCS status name.

Reproduction Steps

1. Configure a custom VCS name (--vcs-status-name="atlantis-dev")
2. Make sure an apply failed (and mergable is a requirement)
3. Try another plan/apply, should still fail (not mergable)

Environment details

• Atlantis version: 0.19.4
• Atlantis flags: --vcs-status-name="atlantis-dev"

Additional Context

Source code line with the issue: gitlab_client.go#L216

[michelmzs]

WIP: #2312