fix: warehouse transformations for tracking plans

[achettyiitr]

Description

The Tracking Plan properties in the Go code differ in type from the response received from rudder-transformer, causing a type mismatch:

• context_tracking_plan_version:
  • Unmarshalling response from rudder-transformer treats all numbers as json.Number (essentially float64).
  • Go code sets it as int.
• context_violation_errors:
  • Unmarshalling response from rudder-transformer returns it as []any.
  • Go code sets it as []types.ValidationError.
• This results in a type mismatch, though the actual data remains correct.

 - 			"context_tracking_plan_version": int(8),
 + 			"context_tracking_plan_version": float64(8),
 - 			"context_violation_errors": []types.ValidationError{
 - 				{
 - 					Type:     "Required-Missing",
 - 					Message:  "must have required property 'name'",
 - 					Meta:     map[string]string{"instancePath": "/traits", "schemaPath": "#/properties/traits/required"},
 - 					Property: "name",
 - 				},
 - 				{
 - 					Type:    "Datatype-Mismatch",
 - 					Message: "must be string",
 - 					Meta: map[string]string{
 - 						"instancePath": "/traits/email",
 - 						"schemaPath":   "#/properties/traits/properties/e"...,
 - 					},
 - 				},
 - 			},
 + 			"context_violation_errors": []any{
 + 				map[string]any{
 + 					"message": string("must have required property 'name'"),
 + 					"meta": map[string]any{
 + 						"instancePath": string("/traits"),
 + 						"schemaPath":   string("#/properties/traits/required"),
 + 					},
 + 					"property": string("name"),
 + 					"type":     string("Required-Missing"),
 + 				},
 + 				map[string]any{
 + 					"message": string("must be string"),
 + 					"meta": map[string]any{
 + 						"instancePath": string("/traits/email"),
 + 						"schemaPath":   string("#/properties/traits/properties/e"...),
 + 					},
 + 					"property": string(""),
 + 					"type":     string("Datatype-Mismatch"),
 + 				},
 + 			},

Linear Ticket

• Resolves WAR-424

Security

• The code changed/added as part of this pull request won't create any security issues with how the software is being used.

[codecov]

Codecov Report

Attention: Patch coverage is 53.48837% with 20 lines in your changes missing coverage. Please review.

Project coverage is 77.02%. Comparing base (5019422) to head (7fce04b).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
warehouse/transformer/datatype.go	39.39%	20 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5662      +/-   ##
==========================================
- Coverage   77.11%   77.02%   -0.10%     
==========================================
  Files         476      476              
  Lines       65613    65654      +41     
==========================================
- Hits        50598    50567      -31     
- Misses      12248    12319      +71     
- Partials     2767     2768       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[vyeshwanth]

why such compile-time check is necessary for this struct?

[achettyiitr]

Currently, we are relying on this struct to do the conversion from map[string]string to map[string]any. In case if something changes in future, we need to aware of it like they added new fields or modified some fields. If we don't do that it would break.

func convertToSliceIfViolationErrors(val any) any {
	if validationErrors, ok := val.([]types.ValidationError); ok {
		result := make([]any, len(validationErrors))
		for i, e := range validationErrors {
			result[i] = map[string]any{
				"type":     e.Type,
				"message":  e.Message,
				"meta":     lo.MapValues(e.Meta, func(value, _ string) any { return value }),
				"property": e.Property,
			}
		}
		return result
	}
	return val
}