Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove transformations v2 flag #5650

Merged
merged 18 commits into from
Apr 1, 2025
Merged

chore: remove transformations v2 flag #5650

merged 18 commits into from
Apr 1, 2025

Conversation

cisse21
Copy link
Member

@cisse21 cisse21 commented Mar 26, 2025 •
edited by atzoum
Loading

Description

clean up transformationsV2 flag and associated code

Linear Ticket

Fixes PIPE-1991

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@cisse21 cisse21 changed the title Chore.remove transformations v2 flag chore: remove transformations v2 flag Mar 26, 2025
@cisse21 cisse21 force-pushed the chore.removeTransformationsV2Flag branch 3 times, most recently from 57c9687 to 8ec903f Compare March 26, 2025 17:56
@cisse21 cisse21 force-pushed the chore.removeTransformationsV2Flag branch from ab0ec11 to 37bd64e Compare March 26, 2025 18:05
@achettyiitr achettyiitr force-pushed the chore.removeTransformationsV2Flag branch from 2fb318b to cbbbe96 Compare March 28, 2025 00:33
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.39316% with 44 lines in your changes missing coverage. Please review.

Project coverage is 76.80%. Comparing base (5019422) to head (4460627).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
processor/transformer/mocks_transformer_client.go 58.88% 37 Missing ⚠️
warehouse/transformer/benchmark/main.go 0.00% 4 Missing ⚠️
processor/manager.go 71.42% 1 Missing and 1 partial ⚠️
processor/processor.go 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5650      +/-   ##
==========================================
- Coverage   77.11%   76.80%   -0.31%     
==========================================
  Files         476      476              
  Lines       65613    65328     -285     
==========================================
- Hits        50598    50178     -420     
- Misses      12248    12379     +131     
- Partials     2767     2771       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cisse21 cisse21 marked this pull request as ready for review March 28, 2025 05:25
@atzoum atzoum requested a review from ktgowtham March 28, 2025 11:32
@cisse21 cisse21 merged commit 3182f9a into master Apr 1, 2025
60 checks passed
@cisse21 cisse21 deleted the chore.removeTransformationsV2Flag branch April 1, 2025 05:30
This was referenced Apr 1, 2025
Closed
Merged
satishrudderstack pushed a commit that referenced this pull request Apr 1, 2025
@devops-github-rudderstack
chore: prerelease 1.46.0-rc.1 (#5676)
f47642c 
🤖 I have created a release *beep* *boop*
---


##
[1.46.0-rc.1](v1.45.0...v1.46.0-rc.1)
(2025-04-01)


### Features

* introduce workers per partition in processor
([#5607](#5607))
([46d61b0](46d61b0))
* move async batch router destinations to use OAuth v2 flow
([#5574](#5574))
([3e35b23](3e35b23))
* option for disabling view creation for bigquery
([#5630](#5630))
([c804547](c804547))
* **processor:** break down transformations step
([#5639](#5639))
([379fcbd](379fcbd))
* **processor:** count pending events without blocking
([#5605](#5605))
([a41c63d](a41c63d))


### Bug Fixes

* compilation error in events_test.go
([#5671](#5671))
([e3ead37](e3ead37))
* increased archival table count alert firing after starting using
dslimit
([#5649](#5649))
([ff799d4](ff799d4))
* remove the noisy combination for version deprecation detection
([#5629](#5629))
([4516a40](4516a40))
* sonnet panic while unmarshalling float64 types
([#5616](#5616))
([c1236e4](c1236e4))
* warehouse transformations for data_warehouse json paths
([#5653](#5653))
([2bbe140](2bbe140))
* warehouse transformations for mandatory fields
([#5658](#5658))
([5019422](5019422))
* warehouse transformations for tracking plans
([#5662](#5662))
([3692063](3692063))


### Miscellaneous

* add limiter to pretransform
([#5622](#5622))
([57ba242](57ba242))
* badger configuration tuning
([#5634](#5634))
([1936b98](1936b98))
* bump sqlconnect-go to 1.18.1
([#5635](#5635))
([f4d78bf](f4d78bf))
* dedup service improvements
([#5602](#5602))
([2e7497e](2e7497e))
* **deps:** bump docker/login-action from 3.3.0 to 3.4.0
([#5604](#5604))
([7e5cea3](7e5cea3))
* **deps:** bump github.com/golang-jwt/jwt/v5 from 5.2.1 to 5.2.2 in the
go_modules group
([#5643](#5643))
([4510413](4510413))
* **deps:** bump golangci/golangci-lint-action from 6 to 7
([#5641](#5641))
([1110b6a](1110b6a))
* **deps:** bump the go-deps group across 1 directory with 5 updates
([#5633](#5633))
([a5a8978](a5a8978))
* **deps:** bump the go-deps group across 1 directory with 5 updates
([#5642](#5642))
([89070bd](89070bd))
* migrate sample event column to text for reporting
([#5503](#5503))
([7d6cbf9](7d6cbf9))
* optimise schema generation function
([#5597](#5597))
([f1818d0](f1818d0))
* remove transformations v2 flag
([#5650](#5650))
([3182f9a](3182f9a))
* sync release v1.45.0 to main branch
([#5617](#5617))
([3669407](3669407))
* use rss for calculating used memory in adaptive payload limiter
([#5656](#5656))
([63ff163](63ff163))
* use sonnet as the default json library
([#5657](#5657))
([4c6e5e0](4c6e5e0))
* version deprecation detection avoid regex
([#5625](#5625))
([0d0e7dd](0d0e7dd))
* version deprecation detection logic
([#5644](#5644))
([345162a](345162a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Apr 1, 2025
Merged
Merged
atzoum pushed a commit that referenced this pull request Apr 1, 2025
@devops-github-rudderstack
chore: prerelease 1.46.0-rc.2 (#5681)
bb6fa03 
🤖 I have created a release *beep* *boop*
---


##
[1.46.0-rc.2](v1.45.0...v1.46.0-rc.2)
(2025-04-01)


### Features

* introduce workers per partition in processor
([#5607](#5607))
([46d61b0](46d61b0))
* move async batch router destinations to use OAuth v2 flow
([#5574](#5574))
([3e35b23](3e35b23))
* option for disabling view creation for bigquery
([#5630](#5630))
([c804547](c804547))
* **processor:** break down transformations step
([#5639](#5639))
([379fcbd](379fcbd))
* **processor:** count pending events without blocking
([#5605](#5605))
([a41c63d](a41c63d))


### Bug Fixes

* compilation error in events_test.go
([#5671](#5671))
([e3ead37](e3ead37))
* increased archival table count alert firing after starting using
dslimit
([#5649](#5649))
([ff799d4](ff799d4))
* remove the noisy combination for version deprecation detection
([#5629](#5629))
([4516a40](4516a40))
* sonnet panic while unmarshalling float64 types
([#5616](#5616))
([c1236e4](c1236e4))
* warehouse transformations for data_warehouse json paths
([#5653](#5653))
([2bbe140](2bbe140))
* warehouse transformations for mandatory fields
([#5658](#5658))
([5019422](5019422))
* warehouse transformations for tracking plans
([#5662](#5662))
([3692063](3692063))


### Miscellaneous

* add limiter to pretransform
([#5622](#5622))
([57ba242](57ba242))
* badger configuration tuning
([#5634](#5634))
([1936b98](1936b98))
* bump sqlconnect-go to 1.18.1
([#5635](#5635))
([f4d78bf](f4d78bf))
* dedup service improvements
([#5602](#5602))
([2e7497e](2e7497e))
* **deps:** bump docker/login-action from 3.3.0 to 3.4.0
([#5604](#5604))
([7e5cea3](7e5cea3))
* **deps:** bump github.com/golang-jwt/jwt/v5 from 5.2.1 to 5.2.2 in the
go_modules group
([#5643](#5643))
([4510413](4510413))
* **deps:** bump golangci/golangci-lint-action from 6 to 7
([#5641](#5641))
([1110b6a](1110b6a))
* **deps:** bump the go-deps group across 1 directory with 5 updates
([#5633](#5633))
([a5a8978](a5a8978))
* **deps:** bump the go-deps group across 1 directory with 5 updates
([#5642](#5642))
([89070bd](89070bd))
* increase max idle connections per host for kinesis
([#5652](#5652))
([6fd8e7c](6fd8e7c))
* migrate sample event column to text for reporting
([#5503](#5503))
([7d6cbf9](7d6cbf9))
* optimise schema generation function
([#5597](#5597))
([f1818d0](f1818d0))
* recover from badgerdb panic
([#5678](#5678))
([9a47bbd](9a47bbd))
* remove transformations v2 flag
([#5650](#5650))
([3182f9a](3182f9a))
* sync release v1.45.0 to main branch
([#5617](#5617))
([3669407](3669407))
* use rss for calculating used memory in adaptive payload limiter
([#5656](#5656))
([63ff163](63ff163))
* use sonnet as the default json library
([#5657](#5657))
([4c6e5e0](4c6e5e0))
* version deprecation detection avoid regex
([#5625](#5625))
([0d0e7dd](0d0e7dd))
* version deprecation detection logic
([#5644](#5644))
([345162a](345162a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atzoum atzoum atzoum approved these changes

@ktgowtham ktgowtham ktgowtham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cisse21 @atzoum @ktgowtham @achettyiitr