Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing image added to page #993

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

ErinClaudio
Copy link
Collaborator

@ErinClaudio ErinClaudio commented Sep 20, 2024

🔗 Issue

#990

✍️ Description

Images are sourced from screenshots - Please let me know if the images are off in sizing and if I should use Figma.

📷 Screenshots/Demos

screencapture-localhost-3000-alta-staff-custom-page-edit-2024-10-01-11_17_15
Screenshot 2024-10-01 at 11 19 11 AM

ErinClaudio and others added 28 commits September 20, 2024 16:02
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Bumps [phonelib](https://github.com/daddyz/phonelib) from 0.9.1 to 0.9.2.
- [Release notes](https://github.com/daddyz/phonelib/releases)
- [Changelog](https://github.com/daddyz/phonelib/blob/master/CHANGELOG.md)
- [Commits](daddyz/phonelib@v0.9.1...v0.9.2)

---
updated-dependencies:
- dependency-name: phonelib
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [puma](https://github.com/puma/puma) from 6.4.2 to 6.4.3.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v6.4.2...v6.4.3)

---
updated-dependencies:
- dependency-name: puma
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from 4.28.0 to 4.28.2.
- [Release notes](https://github.com/protocolbuffers/protobuf/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf/blob/main/protobuf_release.bzl)
- [Commits](https://github.com/protocolbuffers/protobuf/commits)

---
updated-dependencies:
- dependency-name: google-protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sprockets-rails](https://github.com/rails/sprockets-rails) from 3.5.1 to 3.5.2.
- [Release notes](https://github.com/rails/sprockets-rails/releases)
- [Commits](rails/sprockets-rails@v3.5.1...v3.5.2)

---
updated-dependencies:
- dependency-name: sprockets-rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pg](https://github.com/ged/ruby-pg) from 1.5.6 to 1.5.8.
- [Changelog](https://github.com/ged/ruby-pg/blob/master/History.md)
- [Commits](ged/ruby-pg@v1.5.6...v1.5.8)

---
updated-dependencies:
- dependency-name: pg
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [action_policy](https://github.com/palkan/action_policy) from 0.7.0 to 0.7.1.
- [Release notes](https://github.com/palkan/action_policy/releases)
- [Changelog](https://github.com/palkan/action_policy/blob/master/CHANGELOG.md)
- [Commits](palkan/action_policy@v0.7.0...v0.7.1)

---
updated-dependencies:
- dependency-name: action_policy
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [jbuilder](https://github.com/rails/jbuilder) from 2.12.0 to 2.13.0.
- [Release notes](https://github.com/rails/jbuilder/releases)
- [Commits](rails/jbuilder@v2.12.0...v2.13.0)

---
updated-dependencies:
- dependency-name: jbuilder
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pagy](https://github.com/ddnexus/pagy) from 9.0.6 to 9.0.9.
- [Release notes](https://github.com/ddnexus/pagy/releases)
- [Changelog](https://github.com/ddnexus/pagy/blob/master/CHANGELOG.md)
- [Commits](ddnexus/pagy@9.0.6...9.0.9)

---
updated-dependencies:
- dependency-name: pagy
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [active_storage_validations](https://github.com/igorkasyanchuk/active_storage_validations) from 1.1.4 to 1.2.0.
- [Release notes](https://github.com/igorkasyanchuk/active_storage_validations/releases)
- [Changelog](https://github.com/igorkasyanchuk/active_storage_validations/blob/master/CHANGES.md)
- [Commits](https://github.com/igorkasyanchuk/active_storage_validations/commits/1.2.0)

---
updated-dependencies:
- dependency-name: active_storage_validations
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ErinClaudio
Copy link
Collaborator Author

@kasugaijin
I may need to change the position of the image on mobile.

@kasugaijin
Copy link
Collaborator

@ErinClaudio I will ask one of our design folks to add a red border around the pertinent sections in each image - I think that will help communicate the relevant sections better.

@ErinClaudio
Copy link
Collaborator Author

@kasugaijin I can also try

@ErinClaudio
Copy link
Collaborator Author

@kasugaijin
I can adjust the Red how ever you would like.

Screenshot 2024-10-04 at 1 11 26 PM Screenshot 2024-10-04 at 1 11 12 PM

@kasugaijin
Copy link
Collaborator

kasugaijin commented Oct 4, 2024

@kasugaijin I can adjust the Red how ever you would like.

EDIT our designer just added images with a purpler border to the Figma so can you please use those instead? Thanks!
https://www.figma.com/design/0jVgYASUJy0KiX3BVc3dFM/Tasks?node-id=1709-1001&t=Py2nSOgSmbBlw9OL-1

@kasugaijin
Copy link
Collaborator

@ErinClaudio any blockers on this one? No rush...just checking

@kasugaijin
Copy link
Collaborator

@ErinClaudio do you still want to finish this or pass the baton?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants