[0.14.3] Support custom save_path option #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows paths other than Capybara.save_path to be specified
This PR allows a custom save_path option to be configured, instead of defaulting to the Capybara.save_path.
The motivation is wanting to specify an ephemeral directory for downloads (PDFs, CSVs etc) which is cleared between tests, but keep other items saved to the Capybara.save_path (like screenshots) as CI artifacts.
This is especially useful when running multiple specs on a single instance. Here is how we separate the downloads using this patch:
Original PR: #192 (this one has just rebased against 0.14.3)