Support custom save_path option #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows paths other than Capybara.save_path to be specified
stoivo
reviewed
May 31, 2022
| @screen_size ||= DEFAULT_MAXIMIZE_SCREEN_SIZE | ||
|
|
||
| @options[:save_path] = Capybara.save_path.to_s if Capybara.save_path | ||
| @options[:save_path] ||= Capybara.save_path.to_s if Capybara.save_path |
There was a problem hiding this comment.
Don't know if you thought about it but I would have liked the option to be called download_path, maybe also rename it in ferrum. Probably a decisions for @route
Contributor
|
I've superseded this PR here (just rebasing against 0.14.3): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a custom
save_pathoption to be configured, instead of defaulting to theCapybara.save_path.The motivation is wanting to specify an ephemeral directory for downloads (PDFs, CSVs etc) which is cleared between tests, but keep other items saved to the
Capybara.save_path(like screenshots) as CI artifacts.