Use IRB's coloring helper to colorize source#24
Merged
ko1 merged 1 commit intoruby:masterfrom May 24, 2021
Merged
Conversation
Collaborator
|
Thanks.
|
Collaborator
Member
Author
yeah I think we can store the colorized lines inside the frame. is that what you're thinking too? if that sounds good I can implement it. (#28)
Will adding the
ah sorry I didn't even notice that it'd be a problem 😕 |
Collaborator
|
Not sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Since
IRBalready has coloring helpers, I figure it'd better to use it instead of having this library's own one? If this is a reasonable approach, I can use the same helper to colorize the backtrace in another PR. Some notes:3.1's default, theirbshould always have the coloring feature (added after2.7).Result:
