Conversation
|
To me it seems like overkill to introduce a new class. |
|
@ko1 I see. But would you consider accepting the colorization I tested in this PR? st0012#1 |
|
Also, given the amount of frame information we have, it'd be better to have a formatter class extracted for customization like mentioned in #13 (comment). Personally, I'm very interested in maintain this area (presenting frame information) and I've been doing similar work in my own project for more than a year. |
|
I thought a class was necessary because some formats requires computation on all the frames, like the
Yeah that seems more reasonable. Perhaps we can reuse the coloring logic implemented in |
This class will help us format/colorize the backtrace more easily. These are the responsibilities of each class involved in backtrace display:
ThreadClientFrameInforeturn_value_str,call_identifier_str, andlocation_str)BacktraceFormatterFrameInfo's component stringsThis change doesn't change the output