Handle correctly #reminder with infinity. Fixes #187 #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrzasa
force-pushed
the
modulus-reminder-infinity
branch
2 times, most recently
from
575dac0 to
5dd86f1
Compare
mrzasa
force-pushed
the
modulus-reminder-infinity
branch
2 times, most recently
from
ee1f515 to
5675a01
Compare
mrzasa
force-pushed
the
modulus-reminder-infinity
branch
2 times, most recently
from
75fcdc6 to
31cdd32
Compare
mrzasa
force-pushed
the
modulus-reminder-infinity
branch
from
31cdd32 to
21b996b
Compare
|
@mrkn could you take a look? I believe it's ready for review now |
|
@mrzasa Thank you! |
k0kubun
added a commit
to ruby/ruby
that referenced
this pull request
Feb 17, 2023
This test is no longer passing: ``` 1) BigDecimal#remainder returns NaN if Infinity is involved FAILED Expected Infinity.nan? to be truthy but was false /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:58:in `block (2 levels) in <top (required)>' /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:4:in `<top (required)>' ``` ruby/bigdecimal#243
|
Doesn't this need to bump the version? |
eregon
pushed a commit
to ruby/spec
that referenced
this pull request
Feb 27, 2023
This test is no longer passing: ``` 1) BigDecimal#remainder returns NaN if Infinity is involved FAILED Expected Infinity.nan? to be truthy but was false /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:58:in `block (2 levels) in <top (required)>' /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:4:in `<top (required)>' ``` ruby/bigdecimal#243
seven1m
pushed a commit
to seven1m/ruby_spec
that referenced
this pull request
Sep 2, 2023
This test is no longer passing: ``` 1) BigDecimal#remainder returns NaN if Infinity is involved FAILED Expected Infinity.nan? to be truthy but was false /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:58:in `block (2 levels) in <top (required)>' /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:4:in `<top (required)>' ``` ruby/bigdecimal#243
headius
pushed a commit
to headius/spec
that referenced
this pull request
Oct 31, 2024
This test is no longer passing: ``` 1) BigDecimal#remainder returns NaN if Infinity is involved FAILED Expected Infinity.nan? to be truthy but was false /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:58:in `block (2 levels) in <top (required)>' /home/runner/work/ruby/ruby/src/spec/ruby/library/bigdecimal/remainder_spec.rb:4:in `<top (required)>' ``` ruby/bigdecimal#243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #187 by adding a guard to
BigDecimal_divremain. This returns early if the divider is infinity.