Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust modulus/remainder calculation for infinity arguments #187

Closed
jeremyevans opened this issue Mar 10, 2021 · 0 comments · Fixed by #243
Closed

Adjust modulus/remainder calculation for infinity arguments #187

jeremyevans opened this issue Mar 10, 2021 · 0 comments · Fixed by #243

Comments

@jeremyevans
Copy link
Contributor 

require 'bigdecimal'
bd = BigDecimal("4.2")
bd.remainder(BigDecimal("+Infinity")) # => NaN, should be bd
bd.remainder(BigDecimal("-Infinity")) # => NaN, should be bd

See https://bugs.ruby-lang.org/issues/6120

I've submitted a pull request to ruby to fix the issue with Integer/Float, but bigdecimal should be handled separately.
@mrzasa mrzasa mentioned this issue Nov 30, 2022
Merged
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Nov 30, 2022
@mrzasa
Handle correctly #reminder with infinity. Fixes ruby#187
4b1c84b
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Nov 30, 2022
@mrzasa
Handle correctly #remainder with infinity. Fixes ruby#187
575dac0
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Nov 30, 2022
@mrzasa
Handle correctly #remainder with infinity. Fixes ruby#187
5dd86f1
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Dec 16, 2022
@mrzasa
Handle correctly #remainder with infinity. Fixes ruby#187
ee1f515
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Dec 16, 2022
@mrzasa
Handle correctly #remainder with infinity. Fixes ruby#187
5675a01
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Jan 13, 2023
@mrzasa
Handle correctly #remainder with infinity. Fixes ruby#187
d6fb66c
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Jan 13, 2023
@mrzasa
Handle correctly #remainder with infinity. Fixes ruby#187
a835889
mrzasa added a commit to mrzasa/bigdecimal that referenced this issue Jan 13, 2023
@mrzasa
Handle correctly #remainder with infinity. Fixes ruby#187
21b996b
@mrkn mrkn closed this as completed in #243 Feb 17, 2023
mrkn pushed a commit that referenced this issue Feb 17, 2023
@mrzasa @mrkn
Handle correctly #remainder with infinity. Fixes #187
4b8572d
matzbot pushed a commit to ruby/ruby that referenced this issue Feb 17, 2023
@mrzasa @matzbot
[ruby/bigdecimal] Handle correctly #remainder with infinity. Fixes
36e3d46 
ruby/bigdecimal#187

ruby/bigdecimal@4b8572d452
nobu added a commit to nobu/bigdecimal that referenced this issue Feb 21, 2023
@nobu
Bump up to 3.1.4
3a2a7a9 
ruby#187 has changed a behavior and ruby/spec also needed a
follow up at ruby/ruby@0d8ef62.
However, because bigdecimal is a separate gem and can be updated in
older versions of ruby, `RUBY_VERSION` is not appropriate for this
guard.  That means it needs bumped up `BigDecimal::VERSION`.
@nobu nobu mentioned this issue Feb 21, 2023
Merged
matzbot pushed a commit to ruby/ruby that referenced this issue Feb 21, 2023
@nobu @matzbot
[ruby/bigdecimal] Bump up to 3.1.4
0cde887 
ruby/bigdecimal#187 has changed a behavior and ruby/spec also needed a
follow up at 0d8ef62fc293.
However, because bigdecimal is a separate gem and can be updated in
older versions of ruby, `RUBY_VERSION` is not appropriate for this
guard.  That means it needs bumped up `BigDecimal::VERSION`.

ruby/bigdecimal@3a2a7a9353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle correctly #reminder with infinity. Fixes #187 mrzasa/bigdecimal
1 participant
@jeremyevans