Skip to content

Audit and convert tests to test/unit (minitest) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Oct 14, 2014
Merged

Audit and convert tests to test/unit (minitest) #121

Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
342806f
revive entry test
Oct 9, 2014
04ef438
skip failing test
Oct 9, 2014
e520d62
remove test until #117
Oct 9, 2014
5b22480
translate spec/integration/ssl_ber_spec to minitest
Oct 9, 2014
2d406e8
move spec/ber over to test/
Oct 9, 2014
028402b
rename to test_ber.rb
Oct 10, 2014
1538672
convert to test/unit
Oct 10, 2014
a2ff68f
rename to test_array
Oct 10, 2014
f23838f
convert to test/unit
Oct 10, 2014
edb9241
rename to test_string
Oct 10, 2014
fa89e22
convert to test/unit
Oct 10, 2014
d30ce56
convert to test/unit
Oct 10, 2014
8d65ad6
Merge branch 'revive-entry-test' into minitestify
Oct 10, 2014
2415276
add additional ldif parsing entry tests
Oct 10, 2014
006d454
moved tests over to test/test_entry
Oct 10, 2014
98eea8e
rename test_filter_parser
Oct 10, 2014
f73b9c1
convert to test/unit
Oct 10, 2014
c6f7c1f
convert filter spec to test/unit
Oct 10, 2014
7f60ace
rename test_search
Oct 10, 2014
b2d49b9
add MockInstrumentationService to common
Oct 10, 2014
231bd87
convert to test/unit
Oct 10, 2014
ca1c083
rename test_ldap
Oct 10, 2014
9471294
make class name unique
Oct 10, 2014
d40e19b
convert tests to test/unit
Oct 10, 2014
903e459
fix deprecation any_instances
Oct 10, 2014
dcfe8ae
test doesn't like @ldap ivar
Oct 10, 2014
89bb2ed
remove spec_helper
Oct 10, 2014
197c3e9
remove unused metaid gem
Oct 10, 2014
a7377fb
remove .autotest and .rspec
Oct 10, 2014
1018963
generate gemspec file list
Oct 10, 2014
619c622
remove rspec
Oct 10, 2014
f2cec77
rename common to test_helper
Oct 10, 2014
5f25347
Merge branch 'master' into jch-minitestify
mtodd Oct 12, 2014
ef6a167
Use test_helper instead of common now
mtodd Oct 12, 2014
9ecdc5d
Clarify connection instrumentation test class
mtodd Oct 12, 2014
c947b89
server -> host
mtodd Oct 12, 2014
a84e480
Hanlde EHOSTUNREACH error
mtodd Oct 12, 2014
1ac9d61
Another server -> host change
mtodd Oct 12, 2014
3e061e2
reference discussion comment
Oct 13, 2014
36005eb
require_relative test_helper
Oct 13, 2014
ead2469
Merge remote-tracking branch 'jch/minitestify' into minitestify
Oct 13, 2014
1168215
use Minitest::Test
Oct 13, 2014
bb02419
Merge remote-tracking branch 'origin/master' into minitestify
Oct 13, 2014
20f20f8
Revert "use Minitest::Test"
Oct 13, 2014
5fd46be
oops, wrong nesting
Oct 13, 2014
27bd182
missed a spot
Oct 13, 2014
7a4dda5
Switch to assert from assert_predicate
mtodd Oct 14, 2014
a686229
Stub out String#b for Ruby 1.9
mtodd Oct 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reference discussion comment
  • Loading branch information
Jerry Cheung committed Oct 13, 2014
commit 3e061e24e06e6e53e4d47c90cc237acc247efc87
3 changes: 3 additions & 0 deletions test/test_ssl_ber.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ def setup
# The production code operates on sockets, which do need #connect called
# on them to work. Pipes are more robust for this test, so we'll skip
# the #connect call since it fails.
#
# TODO: Replace test with real socket
# https://github.com/ruby-ldap/ruby-net-ldap/pull/121#discussion_r18746386
flexmock(OpenSSL::SSL::SSLSocket).
new_instances.should_receive(:connect => nil)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to remove flexmock and only use minitest/mock here, but I had some difficulty converting this test. It's not high priority, but if someone is interested in tackling it, feel free to talk to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to rebuild this test to use a real socket instead of a pipe since this is why JRuby CI builds fail (mismatch between pipe and socket; thanks strong Java types/Obama). If this is passing as is, let's worry about replacing the mock and pipe later, and I'll assign myself to that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


Expand Down