Skip to content

Audit and convert tests to test/unit (minitest) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 48 commits into from
Oct 14, 2014
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
342806f
revive entry test
Oct 9, 2014
04ef438
skip failing test
Oct 9, 2014
e520d62
remove test until #117
Oct 9, 2014
5b22480
translate spec/integration/ssl_ber_spec to minitest
Oct 9, 2014
2d406e8
move spec/ber over to test/
Oct 9, 2014
028402b
rename to test_ber.rb
Oct 10, 2014
1538672
convert to test/unit
Oct 10, 2014
a2ff68f
rename to test_array
Oct 10, 2014
f23838f
convert to test/unit
Oct 10, 2014
edb9241
rename to test_string
Oct 10, 2014
fa89e22
convert to test/unit
Oct 10, 2014
d30ce56
convert to test/unit
Oct 10, 2014
8d65ad6
Merge branch 'revive-entry-test' into minitestify
Oct 10, 2014
2415276
add additional ldif parsing entry tests
Oct 10, 2014
006d454
moved tests over to test/test_entry
Oct 10, 2014
98eea8e
rename test_filter_parser
Oct 10, 2014
f73b9c1
convert to test/unit
Oct 10, 2014
c6f7c1f
convert filter spec to test/unit
Oct 10, 2014
7f60ace
rename test_search
Oct 10, 2014
b2d49b9
add MockInstrumentationService to common
Oct 10, 2014
231bd87
convert to test/unit
Oct 10, 2014
ca1c083
rename test_ldap
Oct 10, 2014
9471294
make class name unique
Oct 10, 2014
d40e19b
convert tests to test/unit
Oct 10, 2014
903e459
fix deprecation any_instances
Oct 10, 2014
dcfe8ae
test doesn't like @ldap ivar
Oct 10, 2014
89bb2ed
remove spec_helper
Oct 10, 2014
197c3e9
remove unused metaid gem
Oct 10, 2014
a7377fb
remove .autotest and .rspec
Oct 10, 2014
1018963
generate gemspec file list
Oct 10, 2014
619c622
remove rspec
Oct 10, 2014
f2cec77
rename common to test_helper
Oct 10, 2014
5f25347
Merge branch 'master' into jch-minitestify
mtodd Oct 12, 2014
ef6a167
Use test_helper instead of common now
mtodd Oct 12, 2014
9ecdc5d
Clarify connection instrumentation test class
mtodd Oct 12, 2014
c947b89
server -> host
mtodd Oct 12, 2014
a84e480
Hanlde EHOSTUNREACH error
mtodd Oct 12, 2014
1ac9d61
Another server -> host change
mtodd Oct 12, 2014
3e061e2
reference discussion comment
Oct 13, 2014
36005eb
require_relative test_helper
Oct 13, 2014
ead2469
Merge remote-tracking branch 'jch/minitestify' into minitestify
Oct 13, 2014
1168215
use Minitest::Test
Oct 13, 2014
bb02419
Merge remote-tracking branch 'origin/master' into minitestify
Oct 13, 2014
20f20f8
Revert "use Minitest::Test"
Oct 13, 2014
5fd46be
oops, wrong nesting
Oct 13, 2014
27bd182
missed a spot
Oct 13, 2014
7a4dda5
Switch to assert from assert_predicate
mtodd Oct 14, 2014
a686229
Stub out String#b for Ruby 1.9
mtodd Oct 14, 2014
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions .autotest

This file was deleted.

2 changes: 0 additions & 2 deletions .rspec

This file was deleted.

6 changes: 2 additions & 4 deletions Hacking.rdoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ modification to +Contributors.rdoc+ to add yourself.

== Tests

The Net::LDAP team uses RSpec for unit testing; all changes must have rspec
tests for any new or changed features.
The Net::LDAP team uses [Minitest](http://docs.seattlerb.org/minitest/) for unit
testing; all changes must have tests for any new or changed features.

Your changes should have been tested against at least one real LDAP server; the
current tests are not sufficient to find all possible bugs. It's unlikely that
Expand All @@ -57,8 +57,6 @@ installed using RubyGems.

* *hoe*
* *hoe-git*
* *metaid*
* *rspec*
* *flexmock*

== Participation
Expand Down
3 changes: 0 additions & 3 deletions Manifest.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
.autotest
.rspec
.travis.yml
Contributors.rdoc
Gemfile
Expand All @@ -9,7 +7,6 @@ License.rdoc
Manifest.txt
README.rdoc
Rakefile
autotest/discover.rb
lib/net-ldap.rb
lib/net/ber.rb
lib/net/ber/ber_parser.rb
Expand Down
4 changes: 1 addition & 3 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ Hoe.spec 'net-ldap' do |spec|

spec.extra_dev_deps << [ "hoe-git", "~> 1" ]
spec.extra_dev_deps << [ "hoe-gemspec", "~> 1" ]
spec.extra_dev_deps << [ "metaid", "~> 1" ]
spec.extra_dev_deps << [ "flexmock", ">= 1.3.0" ]
spec.extra_dev_deps << [ "rspec", "~> 2.0" ]

spec.clean_globs << "coverage"

Expand Down Expand Up @@ -70,7 +68,7 @@ namespace :old do
end
end

desc "Run a full set of integration and unit tests"
desc "Run a full set of integration and unit tests"
task :cruise => [:test, :spec]

# vim: syntax=ruby
1 change: 0 additions & 1 deletion autotest/discover.rb

This file was deleted.

2 changes: 2 additions & 0 deletions lib/net/ldap/connection.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ def initialize(server)
raise Net::LDAP::LdapError, "No such address or other socket error."
rescue Errno::ECONNREFUSED
raise Net::LDAP::LdapError, "Server #{server[:host]} refused connection on port #{server[:port]}."
rescue Errno::EHOSTUNREACH => error
raise Net::LDAP::LdapError, "Host #{server[:host]} was unreachable (#{error.message})"
end

if server[:encryption]
Expand Down
7 changes: 1 addition & 6 deletions net-ldap.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ the most recent LDAP RFCs (4510-4519, plutions of 4520-4532).}
s.email = ["blackhedd@rubyforge.org", "gemiel@gmail.com", "rory.ocon@gmail.com", "kaspar.schiess@absurd.li", "austin@rubyforge.org"]
s.extra_rdoc_files = ["Manifest.txt", "Contributors.rdoc", "Hacking.rdoc", "History.rdoc", "License.rdoc", "README.rdoc"]
s.files = `git ls-files`.split $/
s.test_files = s.files.grep(%r{^test})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s.homepage = %q{http://github.com/ruby-ldap/ruby-net-ldap}
s.rdoc_options = ["--main", "README.rdoc"]
s.require_paths = ["lib"]
Expand All @@ -40,24 +41,18 @@ the most recent LDAP RFCs (4510-4519, plutions of 4520-4532).}
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
s.add_development_dependency(%q<hoe-git>, ["~> 1"])
s.add_development_dependency(%q<hoe-gemspec>, ["~> 1"])
s.add_development_dependency(%q<metaid>, ["~> 1"])
s.add_development_dependency(%q<flexmock>, [">= 1.3.0"])
s.add_development_dependency(%q<rspec>, ["~> 2.0"])
s.add_development_dependency(%q<hoe>, [">= 2.9.1"])
else
s.add_dependency(%q<hoe-git>, ["~> 1"])
s.add_dependency(%q<hoe-gemspec>, ["~> 1"])
s.add_dependency(%q<metaid>, ["~> 1"])
s.add_dependency(%q<flexmock>, [">= 1.3.0"])
s.add_dependency(%q<rspec>, ["~> 2.0"])
s.add_dependency(%q<hoe>, [">= 2.9.1"])
end
else
s.add_dependency(%q<hoe-git>, ["~> 1"])
s.add_dependency(%q<hoe-gemspec>, ["~> 1"])
s.add_dependency(%q<metaid>, ["~> 1"])
s.add_dependency(%q<flexmock>, [">= 1.3.0"])
s.add_dependency(%q<rspec>, ["~> 2.0"])
s.add_dependency(%q<hoe>, [">= 2.9.1"])
end
end
39 changes: 0 additions & 39 deletions spec/integration/ssl_ber_spec.rb

This file was deleted.

140 changes: 0 additions & 140 deletions spec/unit/ber/ber_spec.rb

This file was deleted.

24 changes: 0 additions & 24 deletions spec/unit/ber/core_ext/array_spec.rb

This file was deleted.

51 changes: 0 additions & 51 deletions spec/unit/ber/core_ext/string_spec.rb

This file was deleted.

Loading