Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently return array from bulk lookup, even if translation(s) missing #628

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Consistently return array from bulk lookup, even if translation(s) missing #628

merged 2 commits into from
Jul 10, 2022

Commits on Jun 6, 2022

  1. Add test for existing bulk lookup failure behavior 

    Currently, doing a bulk lookup for multiple keys returns only the "translation
missing" string for the first key. This adds a test capturing that.
    @sambostock
    sambostock committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    5611700 View commit details
    Browse the repository at this point in the history

  2. Consistently return array on bulk lookup 

    In the event of we fail to lookup one or more keys during a bulk lookup, we
should still return an array of messages.
    @sambostock
    sambostock committed Jun 6, 2022
    Configuration menu
    Copy the full SHA
    8a698d7 View commit details
    Browse the repository at this point in the history