Consistently return array from bulk lookup, even if translation(s) missing #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, doing a bulk lookup for multiple keys returns only the "translation missing" string for the first key. This adds a test capturing that.
In the event of we fail to lookup one or more keys during a bulk lookup, we should still return an array of messages.
radar
approved these changes
Jul 10, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of we fail to lookup one or more keys during a bulk lookup, we should still return an array of translation results.
Currently, doing a bulk lookup for multiple keys returns only the "translation missing" string for the first key.