-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose translations
in simple backend and load translations only when not loaded
#353
Expose translations
in simple backend and load translations only when not loaded
#353
Conversation
I think the Travis tests may have failed because this branch wasn't up-to-date with master. I've just pushed a commit which should fix that. Thanks very much for making this PR! |
many jobs have failed due to |
@radar I think this trick may work: lastnpe/lastnpe.github.io#2 (more details in this thread: rubygems/bundler#4467 (comment), especially the last comment) |
Thanks @sandstrom. I will try deleting the |
Hei! Maybe CI will pass now since lock files live in source control? |
b257a4a
to
2152beb
Compare
@deivid-rodriguez build is green now after rebasing |
@PikachuEXE looks like just a merge conflict on one file. Anything I can do to help? |
2152beb
to
f93f78b
Compare
f93f78b
to
ae47118
Compare
Updated code to expose Edit 1: sssss |
@radar from other PRs it looks like you've been the one setting up things for new versions. Pikachu tidied this up and it LGTM. |
Seems fine to me! |
Pull Request for #254