Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose translations in simple backend and load translations only when not loaded #353

Merged

Conversation

PikachuEXE
Copy link
Contributor

Pull Request for #254

@radar
Copy link
Collaborator

radar commented Nov 24, 2016

I think the Travis tests may have failed because this branch wasn't up-to-date with master. I've just pushed a commit which should fix that.

Thanks very much for making this PR!

@PikachuEXE
Copy link
Contributor Author

many jobs have failed due to
Your Gemfile.lock is corrupt

@sandstrom
Copy link
Contributor

@radar I think this trick may work: lastnpe/lastnpe.github.io#2

(more details in this thread: rubygems/bundler#4467 (comment), especially the last comment)

@radar
Copy link
Collaborator

radar commented Dec 4, 2016

Thanks @sandstrom. I will try deleting the Gemfile.lock file.

@deivid-rodriguez
Copy link

Hei! Maybe CI will pass now since lock files live in source control?

@PikachuEXE PikachuEXE force-pushed the feature/change-translations-behaviour branch from b257a4a to 2152beb Compare April 25, 2017 02:18
@PikachuEXE
Copy link
Contributor Author

@deivid-rodriguez build is green now after rebasing

@dillonwelch
Copy link
Contributor

@PikachuEXE looks like just a merge conflict on one file. Anything I can do to help?

@PikachuEXE PikachuEXE force-pushed the feature/change-translations-behaviour branch from 2152beb to f93f78b Compare September 21, 2018 02:47
@PikachuEXE PikachuEXE force-pushed the feature/change-translations-behaviour branch from f93f78b to ae47118 Compare September 21, 2018 02:50
@PikachuEXE
Copy link
Contributor Author

PikachuEXE commented Sep 21, 2018

Updated code to expose #translations only and allow performing initialization when called with argument
The new argument is defined using optional keyword argument but should be fine since I18n requires ruby >= 2.0.0

Edit 1: sssss

@dillonwelch
Copy link
Contributor

@radar from other PRs it looks like you've been the one setting up things for new versions. Pikachu tidied this up and it LGTM.

@radar
Copy link
Collaborator

radar commented Sep 23, 2018

Seems fine to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants