Fix flaky localization specs #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierm
force-pushed
the
1630-fix_flaky_localization_specs
branch
from
58b5f01
to
375a83e
Compare
Not doing so might cause the following test to use translations for only one locale. This scenario happens if the previous test executes I18n.reload!, which resets I18n.config.backend's "@translations" instance variable. So, the sequence could be as follows: 1. The previous tests sets `@translations = nil` 2. This test stubs `available_locales` to `[:en]` 3. `@translations` gets only translations for `en` 4. The following test doesn't find translations for Spanish and fails
javierm
force-pushed
the
1630-fix_flaky_localization_specs
branch
from
375a83e
to
0745c78
Compare
voodoorai2000
approved these changes
Dec 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Objectives
Fix the flaky specs that appeared in
spec/features/localization_spec.rb:34("Localization Changing the locale") andspec/features/localization_spec.rb:20("Localization Available locales appear in the locale switcher").Explain why the test is flaky, or under which conditions/scenario it fails randomly
These specs fail when executed after
spec/customization_engine_spec.rb:19andspec/features/localization_spec.rb:44, causing the following sequence:I18n.reload!, which causesI18n.config.backendto set@translations = nil.available_localesto[:en], causing@translationsto get only translations for:en.@translationsonly has the English ones, and fails.Explain why your PR fixes it
Reloading
I18nafter the test stubbingavailable_localessolves the problem, since it sets@translations = nilagain, and so it fetches translations for Spanish (and all the other languages).Notes
init_translations, sincei18ndoesn't automatically init translations