Don't rely on Hashie::Mash (compatibility with hashie 3.3.0)

[maciejmajewski]

Hashie 3.3.0 introduced incompatible changes to converting values in Hashie::Mash hashie/hashie#197

I am not sure if this isn't a bug in Hashie, however here is a fix making grape work with Hashie 3.3.0.

Closes #736

[dblock]

So the Hashie change was intentional. But maybe the key? part is a bug? Looking ...

[dblock]

Thanks for this. I've yanked Hashie 3.3.0, reverted hashie/hashie#197 which is the root cause of this, in hashie/hashie#217, and cut 3.3.1. Things should be back to normal now.

I do like it if Grape could not depend on Hashie::Mash though, maybe this should still be merged. What do you think @maciejmajewski?

[maciejmajewski]

@dblock I would use Params < ::Hash with Hashie extensions, however I would remove the convert_value method [1]. This method is required only by Grape::Validations::CoerceValidator coerces file spec [2]. Without it the returned hash has no MethodAccess-capabilities. Anyway I am wondering if the coercing there is correct, I would expect that requires :file, coerce: Rack::Multipart::UploadedFile returns instance of UploadedFile class, but returns a Hash.

[1] https://github.com/intridea/grape/pull/737/files#diff-aa7747a545932e24134dc7e9ba0fa9c6R8
[2] https://github.com/intridea/grape/blob/master/spec/grape/validations/coerce_spec.rb#L179

[dblock]

I am with you @maciejmajewski - convert_value here feels like a hack. Would love to see this PR go further.

[dblock]

Bump?

[dblock]

I am still interested in this after #1610

[dblock]

I believe this is fully addressed via #1594. Please reopen if you think otherwise.