-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Hashie::Mash with ActiveSupport::HashWithIndifferentAccess. #1610
Replace Hashie::Mash with ActiveSupport::HashWithIndifferentAccess. #1610
Conversation
b88d75d
to
d260817
Compare
@namusyaka @marshall-lee @james2m Would appreciate a careful code review and comments/feedback, I'll iterate quickly. I am a little concerned that we're losing method access, since it probably will affect quite a few people but I think it's the right thing to do. |
9dbb459
to
62b8b76
Compare
💚 |
@dblock thanks for finishing that up, looks similar to what I have locally, I just didn't have time to polish up and complete as I'm traveling until 17th. The cleaned up tests is a big relief too! 😬 |
You've done an excellent job up this far @james2m, thanks for your big effort! |
💚 👍 |
How are we feeling about merging this? |
I'm happy with it. Using it in a new app with Rails 5.1 release candidate. If I had more tinkering time I'd probably reorganise the files under /extensions as it feels like a dumping ground right now, but nothing functional. |
e27a374
to
717faed
Compare
717faed
to
d931da3
Compare
I merged this, lets see what happens ;) |
Replaces #1594, includes a way to set the class name globally.