OPTIONS regression 2

[karlfreeman]

Having pulled down the latest master which includes #582. It appears that my test suite exploded.

Turns out the fix to fix a regression has regressed 🐛.

class NamespacedEndpoint < Grape::API
  namespace :foo do
    get 'regression'
      'no-fun'
    end
  end
end
class CollectionOfEndpoints < Grape::API
  get 'no-regression'
    'fun'
  end
  mount NamespacedEndpoint
end
class Root < Grape::API
  mount CollectionOfEndpoints
end

Going to try and look at this myself but limited on time. Not sure what the best way to go forward with these OPTIONS regressions are. The tests we have clearly aren't capturing the use cases which means we're somewhat chasing our tails 😒.

[stevschmid]

I will definitely take a look at it tomorrow. I think the amount of OPTIONS issues recently is an indicator that the code is fragile and the tests don't cover all use cases. I'll try to refactor add_head_not_allowed_methods_and_options_methods and extend the test suite.

[stevschmid]

I identified the issue and I'm working towards a PR. Stay tuned.

[dblock]

Bump @stevschmid. Getting antsy about doing a release soon and I really want to have this one fixed. Need help? If you are not going to make a PR with a fix, appreciate at least some explanation of what you found so far.

[stevschmid]

I catched a cold last week and was unable to work on this issue. I pushed my solution in #609, but I'm not entirely sold on my approach there. Maybe it helps someone to come up with a better solution. I do not have the time right now to fiddle with all the internals to make it feel like less of a hack (e.g. by having the ability to collect all routes without versioning information).

[dblock]

@stevschmid Thanks so much. I've merged that commit, i think it's not ideal, but we can live with it.