Stop yielding skip value #2341
Merged
Stop yielding skip value #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Jun 24, 2023
| ) | ||
| end | ||
| end | ||
|
|
||
| context 'when missing optional value' do | ||
| let(:params) { [Grape::DSL::Parameters::EmptyOptionalValue, 10] } | ||
|
|
||
| it 'marks params with skipped values' do | ||
| it 'doest not yield skipped values' do |
I'm not sure its a breaking change. There's never been a validation done against a skip value. It's was always returned by base class when validating. I figured that why yield these values when it's actually returned automatically. |
I think you're right. I am going to YOLO it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will stop yielding
skipvalue since iterators are already ignoringskipvalues.Resolves #2329