Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not yielding skipping value ? #2329

Closed
ericproulx opened this issue May 16, 2023 · 1 comment · Fixed by #2341
Closed

Not yielding skipping value ? #2329

ericproulx opened this issue May 16, 2023 · 1 comment · Fixed by #2341
Labels

Comments

@ericproulx
Copy link
Contributor

ericproulx commented May 16, 2023

Hi,

multiple_attributes_iterator and single_attribute_iterator are yielding attribute that are eventually skip here and here. Does it make sense to just not yield them and forget the next if skip_value ? We would have 1 iteration saved per skip

@dblock
Copy link
Member

dblock commented May 16, 2023

Probably, but that must exist for a reason. I would change it and see what specs break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants