Don't cache Class.instance_methods
#2328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
class-dymanic-methods
branch
from
743eec6 to
2f4a462
Compare
|
Care to add a test for this? Could be an integration test that adds a method to |
casperisfine
force-pushed
the
class-dymanic-methods
branch
from
2f4a462 to
eb57e56
Compare
|
Done. |
|
Test looks good. CHANGELOG needed, danger is about to complain. |
casperisfine
force-pushed
the
class-dymanic-methods
branch
2 times, most recently
from
b5c6f79 to
432d36c
Compare
|
Done. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
casperisfine
force-pushed
the
class-dymanic-methods
branch
from
432d36c to
4c30e8d
Compare
|
Done. |
casperisfine
force-pushed
the
class-dymanic-methods
branch
from
4c30e8d to
fa06395
Compare
dblock
reviewed
May 19, 2023
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * [#2328](https://github.com/ruby-grape/grape/pull/2328): Don't cache Class.instance_methods - [@byroot](https://github.com/byroot). | |||
There was a problem hiding this comment.
🤦 there's an extra space in front of *
SORRY, we'll get there
There was a problem hiding this comment.
No worries, that's on me for doing these silly mistakes.
Fix: ruby-grape#2258 Some gems or app code may define methods on `Class` after `grape` is loaaded but before `override_all_methods!` is called. As such it's better to check `Class.method_defined?` when doing the override.
casperisfine
force-pushed
the
class-dymanic-methods
branch
from
fa06395 to
4f27305
Compare
|
Done. |
dblock
approved these changes
May 19, 2023
|
Merged, thanks for hanging in here with me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2258
Some gems or app code may define methods on
Classaftergrapeis loaaded but beforeoverride_all_methods!is called.As such it's better to check
Class.method_defined?when doing the override.