Merge pull request #2328 from casperisfine/class-dymanic-methods

Don't cache `Class.instance_methods`

Author: dblock

CHANGELOG.md

@@ -9,6 +9,7 @@
 
 #### Fixes
 
+* [#2328](https://github.com/ruby-grape/grape/pull/2328): Don't cache Class.instance_methods - [@byroot](https://github.com/byroot).
 * Your contribution here.
 
 ## 1.7.1 (2023/05/14)

lib/grape/api.rb

@@ -8,7 +8,7 @@ module Grape
   # should subclass this class in order to build an API.
   class API
     # Class methods that we want to call on the API rather than on the API object
-    NON_OVERRIDABLE = (Class.new.methods + %i[call call! configuration compile! inherited]).freeze
+    NON_OVERRIDABLE = %i[call call! configuration compile! inherited].freeze
 
     class Boolean
       def self.build(val)
@@ -50,7 +50,7 @@ def initial_setup(base_instance_parent)
 
       # Redefines all methods so that are forwarded to add_setup and be recorded
       def override_all_methods!
-        (base_instance.methods - NON_OVERRIDABLE).each do |method_override|
+        (base_instance.methods - Class.methods - NON_OVERRIDABLE).each do |method_override|
           define_singleton_method(method_override) do |*args, &block|
             add_setup(method_override, *args, &block)
           end

spec/grape/api_spec.rb

@@ -4226,6 +4226,15 @@ def self.inherited(child_api)
       end
     end
 
+    it 'does not override methods inherited from Class' do
+      Class.define_method(:test_method) {}
+      subclass = Class.new(described_class)
+      expect(subclass).not_to receive(:add_setup)
+      subclass.test_method
+    ensure
+      Class.remove_method(:test_method)
+    end
+
     context 'overriding via composition' do
       module Inherited
         def inherited(api)