You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the discussion #2298, this PR is intended to limit Grape to Rack < 3 until the issue is resolved.
Also rack-test has been updated to its latest version 2.0.2. This PR changes the way multipart is processed and spec/grape/endpoint_spec.rb#427 has been updated to reflect that.
@dblock by updating rack-test, I had to change all the gemfiles. I was wondering if it would possible to use add_development_dependency in gemspec instead. I know the gem appraisal does the work but we could shorten all the gemfiles by leveraging the gemspec.
@dblock by updating rack-test, I had to change all the gemfiles. I was wondering if it would possible to use add_development_dependency in gemspec instead. I know the gem appraisal does the work but we could shorten all the gemfiles by leveraging the gemspec.
We sure can, but mind that some of the appraisals may want to lock a development dependency at a different version explicitly in Gemfile - we are just getting lucky with rack-test that can be "anything compatible". This means that in the future you might need to undo that change. I'd just leave it alone and let appraisal do its job.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion #2298, this PR is intended to limit Grape to Rack < 3 until the issue is resolved.
Also
rack-testhas been updated to its latest version 2.0.2. This PR changes the way multipart is processed andspec/grape/endpoint_spec.rb#427has been updated to reflect that.Fixes #2278
Closes #2279