Test with rack-test 2.0 #2279
Closed
Test with rack-test 2.0 #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those two tests endpoint_spec are in the end testing internal details of rack-test. Change them so that they still test what was intended, but in a more robust way that does not break on changes on the implementation details of rack-test. Fixes: ruby-grape#2278
terceiro
force-pushed
the
rack-test-2.0
branch
from
5951b8c
to
ab91474
Compare
Here's an example of a CHANGELOG.md entry: * [#2279](https://github.com/ruby-grape/grape/pull/2279): Test with rack-test 2.0 - [@terceiro](https://github.com/terceiro).Generated by 🚫 Danger |
dblock
reviewed
Aug 22, 2022
| @@ -432,7 +431,7 @@ def app | |||
| end | |||
| post '/upload', { file: '' }, 'CONTENT_TYPE' => 'multipart/form-data; boundary=foobar' | |||
| expect(last_response.status).to eq(400) | |||
| expect(last_response.body).to eq('empty message body supplied with multipart/form-data; boundary=foobar content-type') | |||
| expect(last_response.body).not_to be_empty | |||
There was a problem hiding this comment.
Are we losing something in this test? Is there something we can assert that ensures that the error is empty message body?
There was a problem hiding this comment.
good question. TBH I could not figure out yet where this message in the body comes from. I thought it came from rack-test, but it doesn't. It seems that the new rack-test changes the way it composes requests with file uploads though.
|
Want to finish this @terceiro ? |
Merged
|
was this closed by mistake? I think we should get support for rack-test 2.0 at some point |
|
no, sorry for the noise. that MR does seem to address the issues here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those two tests endpoint_spec are in the end testing internal details of
rack-test. Change them so that they still test what was intended, but in
a more robust way that does not break on changes on the implementation
details of rack-test.
Fixes: #2278