Conversation
|
Before you waste any time in investigating failures on CI, the failing test related to arrays and XMLs is addressed in #2144 |
Here's an example of a CHANGELOG.md entry: * [#2145](https://github.com/ruby-grape/grape/pull/2145): Try ruby 3 0 - [@ericproulx](https://github.com/ericproulx).Generated by 🚫 danger |
|
Fix #2142 |
|
We're moving to GH actions in #2143, which I just merged, update? |
ce94b20 to
47fe37a
Compare
Add rails_6_1.gemfile
Add rails_6_1.gemfile
Transform **options into *options since Rack::Builder is calling middleware with .new(klass, *args, &block)
Add ** to versioned_path
Explicit ** for macro options
Replace ** by * since its anonymous
Add explicit { }
Transform **opts to *opts since its called with with (*args, &block)
Add explicit **
Transform **opts to *opts since rspec-mock is calling .new(*args)
Add 6_1 gemfile
Add CHANGELOG
Explicitly require active_support/core_ext/array/conversions for the Array#to_xml method
Enable GitHub Actions with updated Rubocop and Danger
Merge master
Rubocop gemfiles
Explicitly require active_support/core_ext/array/conversions for the Array#to_xml method
8576ba1 to
7f4f72c
Compare
|
This Danger failure is interesting. Think that Danger is not able to interact with it's old entires because it uses a different GitHub token than before. We could either live over the transitiontime or reuse the old token from TravisCI for the danger integration. Maybe it also could work if a maintainer would delete the old danger entry created from the Travis run, ping @dblock |
|
Most of the work is :
The last one is quite particular. For the middlewares, I figured that Rack::Builder is instantiating them like this middleware.new(app, *args, &block)It's the same within the Grape::Middleware::Stack. Therefore, I replace the Same thing happened with the original.call(*args, &block)I haven't figured how to make a call properly when having a double splat param with a That's why I made theses changes |
|
Instead of having |
|
I'm down with whatever solution. Can merge on green - |
Check my previous comment, think its because the token for danger has changed and it cannpt interact with previous entries |
|
I merged this, YOLO |
Just trying grape with ruby 3.0. I might have to update rubocop also